Skip to content

fix: stop ECC flow when PDK cell masters are missing - #255

Merged
Emin017 merged 4 commits into
mainfrom
yell/fixbug_pdk_check
Sep 3, 2026
Merged

fix: stop ECC flow when PDK cell masters are missing#255
Emin017 merged 4 commits into
mainfrom
yell/fixbug_pdk_check

Conversation

@Yell-walkalone

@Yell-walkalone Yell-walkalone commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

What Changed

  • stop ECC flow when PDK cell masters are missing

Scope

Select the areas touched by this PR:

  • CLI - command behavior, Typer command surface, output formats, or workspace commands.
  • Flow/runtime - workspace lifecycle, EngineFlow, step execution, logs, metrics, or artifacts.
  • EDA integration - Yosys, ECC-Tools, DreamPlace, KLayout, PDKs, or native/runtime wrappers.
  • Build/package - Nix, PyInstaller, wheels, uv.lock, or release artifacts.
  • CI/release - GitHub Actions, version checks, changelog, or release automation.
  • Tests/docs only

Runtime And Packaging Impact

  • No runtime or packaging impact
  • CLI output or machine-readable contract changed
  • Workspace layout, flow state, or artifact paths changed
  • Native toolchain or wrapper behavior changed
  • ecc-tools or ecc-dreamplace dependency changed
  • PyInstaller, Nix, or release artifact changed

Notes:

Validation

List the commands you ran. Mark checks that are not applicable as N/A.

  • uv run pytest test/
  • uv run ruff check chipcompiler test
  • uv run ruff format --check chipcompiler test
  • PyInstaller smoke: ecc --help, ecc --version, ecc version --json
  • Nix smoke: nix run .#cli -- --help
  • Manual flow smoke:
  • Other:

Skipped checks and reason:

Checklist

  • I kept the change scoped to ECC.
  • I updated docs or user-facing CLI text where behavior changed.
  • I included lockfile or version metadata updates when dependencies changed.
  • I documented any submodule updates and why they are needed.
  • I did not include local caches, virtual environments, or generated build outputs.
  • I explained skipped validation and remaining risk.

Comment thread docs/superpowers/specs/2026-09-01-ecc-pdk-master-resolution-design.md Outdated
@Emin017 Emin017 added this to the 0.1.0-alpha.12 milestone Sep 3, 2026
@Emin017 Emin017 added the bug Something isn't working label Sep 3, 2026
@Emin017
Emin017 enabled auto-merge (squash) September 3, 2026 09:27
@Emin017
Emin017 merged commit 50c1d7a into main Sep 3, 2026
5 checks passed
@Yell-walkalone
Yell-walkalone deleted the yell/fixbug_pdk_check branch September 4, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants