feat(data): accept post-route LEC aliases in dynamic flow steps - #253
Open
Emin017 wants to merge 1 commit into
Open
feat(data): accept post-route LEC aliases in dynamic flow steps#253Emin017 wants to merge 1 commit into
Emin017 wants to merge 1 commit into
Conversation
Normalize postlec/postroutelec (with the existing separator handling for underscore, dash, and space, case-insensitive) to the canonical postRouteLec step name so flow_config selections keep the LEC step instead of silently dropping it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
_normalize_flow_step_name(dynamic flow construction from GUI/agentflow_config) now aliasespostlec/postroutelec— with the existing case-insensitive,_/-/space-separator-tolerant normalization — to the canonicalpostRouteLecstep name.postRouteLecsurvived normalization; hand-written variants such aspost_route_lecorPost-Route-LECfell through unchanged, failed the canonical harden-flow intersection inbuild_dynamic_flow_data, and the post-route LEC step was silently dropped from the workspace's initialflow.json. Every other coarse step already had aliases; the LEC step had none.flow_config.steps, plus alias acceptance instart_step/end_stepboundary derivation, asserting canonical("postRouteLec", "yosys_lec")output.No behavior change for existing workspaces: this only widens which
flow_configspellings keep the LEC step at workspace-creation time; persistedflow.jsonfiles are untouched.Scope
uv.lock, or release artifacts.Flow/runtime is checked for workspace lifecycle only: initial
flow.jsonconstruction indata/workspace/__init__.py. No engine, tool, or artifact behavior changes.Runtime And Packaging Impact
ecc-toolsorecc-dreamplacedependency changedNotes:
flow_configspellings likepost_route_lecnow resolve topostRouteLecinstead of being silently filtered out, so affected workspace creations keep the LEC step inflow.json. Existing workspaces and all current callers that pass canonical names see no difference.Validation
uv run pytest test/— 1534 pass, 4 skipped, 4 xfailed; 2 pre-existing failures (test/integration/test_rcx_flow.py::test_ics55_gcdandtest_rtl2gds_flow.py::test_ics55_gcd, bothAttributeErrorat setup) reproduce identically on1f910c3c(main) in this environment, unrelated to this change.uv run ruff check chipcompiler test(all checks passed)uv run ruff format --check chipcompiler test(239 files already formatted)ecc --help,ecc --version,ecc version --jsonnix run .#cli -- --helpgpt-5.6-sol:high) of the commit; findings (alias-contract wording, separator coverage, parametrized tests) addressed in the amended commit.Skipped checks and reason:
Checklist
Notes: no user-facing CLI text exists for flow_config spellings; no dependency or submodule changes.