Repository navigation
Conversation
Assisted-by: OpenAI Codex
|
Thanks for your first pull request! We appreciate the contribution. Before review, please make sure tests pass: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reading a typed duration of one microsecond produces
1e-06s, which the Go-style duration parser rejects. Negative durations fail too, including values written throughtimedelta. Format fractional seconds with integer arithmetic in decimal notation and accept one optional leading sign for the whole duration. Add signed/compound/invalid-sign cases and protobuf duration round trips, retaining Python's microsecond precision.Test plan
cd sdk && ../.venv-ci/bin/python -m pytest --cov --cov-report=term-missing: 327 passed, 13 live-server tests skipped, 100% coverage (upstream baseline: 311 passed, 13 skipped, 100%)..venv-ci/bin/ruff check sdk/src/ sdk/tests/and.venv-ci/bin/ruff format --check sdk/src/ sdk/tests/: pass.cd sdk && ../.venv-ci/bin/mypy src/: pass on all 29 source files..venv-ci/bin/python -m build sdk/ --wheel --outdir ../validation/decree-wheel: pass;py.typedand.pyicontents verified.git diff --check: pass.Validation used Python 3.12.14 and the SDK's dev dependencies. Live-server integration and Docker example execution were not run; the existing AsyncMock warning remains. No protobuf schemas or generated stubs changed.
Assisted-by: OpenAI Codex