Repository navigation
chore(deps): ignore grpcio-tools>=1.82.1 pending protobuf 7 migration - #175
Merged
Merged
Conversation
grpcio-tools 1.82.1 raised its own floor to protobuf>=7.35.1, which conflicts with our protobuf<7 pin in sdk/pyproject.toml (broke decree-python#174). The existing protobuf>=7 ignore rule assumed a future grpcio-tools release would support protobuf 7.x while retaining protobuf<7 support; it didn't, it just moved forward. Ignore grpcio-tools>=1.82.1 too, until we deliberately migrate to protobuf 7. Refs #174 Co-Authored-By: Claude <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
protobuf>=7.35.1, which conflicts with ourprotobuf<7pin insdk/pyproject.toml. This broke CI on chore(deps-dev): update grpcio-tools requirement from >=1.81.1 to >=1.82.1 in /sdk #174 (dependabot's grpcio-tools bump), which cannot merge until this is resolved.protobuf>=7assumed a future grpcio-tools release would add protobuf 7.x support while retaining protobuf<7 compatibility. It didn't — 1.82.1 just moved its floor forward.grpcio-tools>=1.82.1so dependabot stops proposing bumps we can't take, until we deliberately migrate the SDK to protobuf 7.Test plan
Refs #174