Repository navigation
fix: correct supported server version floor to v0.8.0 - #145
Merged
Merged
Conversation
SUPPORTED_SERVER_VERSION advertised >=0.3.0,<1.0.0, but the SDK's proto stubs already target decree v0.8.0+. The stale floor told users that servers as old as v0.3.0 were supported when they are not. Bump the source field in sdk/pyproject.toml, regenerate _constants.py, update README, sdk/README, and docs/index, and realign the tests that asserted the old default range. Add a changelog entry. Co-Authored-By: Claude <[email protected]> Refs opendecree/decree#906
zeevdr
added
size: S
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
2 tasks done
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SUPPORTED_SERVER_VERSIONadvertised>=0.3.0,<1.0.0, but the SDK's proto stubs already target decree v0.8.0+. The stale floor told users that servers as old as v0.3.0 were supported when they are not — the correctness half of the cross-repo docs sweep.sdk/pyproject.toml, regenerated_constants.py, and alignedREADME.md,sdk/README.md, anddocs/index.mdto the real floor (matching the TypeScript SDK's phrasing).CHANGELOGentry.Test plan
make pre-commit— ruff lint + format, mypy, pytest: 311 passed, 13 skipped, 100% coveragepython build/gen-constants.pyregenerates_constants.pyto>=0.8.0,<1.0.0Refs opendecree/decree#906