Repository navigation
fix(watcher): bound WatchedField change queue to prevent unbounded memory growth - #110
Merged
Merged
Conversation
…mory growth Add max_queue_size parameter (default 1024) to WatchedField and AsyncWatchedField. When the queue is full, the oldest entry is dropped (drop-oldest strategy) and dropped_changes is incremented. A warning is logged on each drop. Matches the TypeScript SDK's queue overflow semantics. Closes #100 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
6 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_queue_sizeparameter (default 1024) toWatchedFieldandAsyncWatchedFielddropped_changesis incrementedWARNINGon each drop (path, max size, running total)ConfigWatcher.field()andAsyncConfigWatcher.field()accept and forwardmax_queue_sizeDEFAULT_QUEUE_SIZE = 1024, drop-oldest)Test plan
dropped_changesstarts at 0 and increments once per overflowmax_queue_sizeentriesNsurvive)max_queue_sizeconstructor arg sets the bound; default is 1024changes()/async foriterator yields only surviving entries after overflow🤖 Generated with Claude Code