Repository navigation
feat(channel): expose message-size and keepalive options - #104
Merged
Merged
Conversation
Add optional max_send_message_length and max_recv_message_length parameters to create_channel and create_aio_channel. When set, the corresponding grpc.max_send_message_length / grpc.max_receive_message_length options are appended; when omitted the gRPC default (4 MB) applies unchanged. Keepalive tuning constants (time, timeout, permit_without_calls, reconnect backoffs) are also promoted from hard-coded internals to keyword arguments with the same defaults, so callers can tune them without forking the factory. Closes #67 Co-Authored-By: Claude <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_send_message_lengthandmax_recv_message_lengthare now optional kwargs on bothcreate_channelandcreate_aio_channel; omitting them preserves the existing behaviour.Test plan
test_message_size_options_included_when_set— verifies options appear in channel call when values are providedtest_message_size_options_absent_by_default— verifies options are absent when not providedtest_keepalive_override— verifies non-default keepalive values propagate correctlyCloses #67