Repository navigation
At loading, the cog may not render properly for a few seconds - #566
Merged
Merged
Conversation
PrimeIcons is now imported as `primeicons.woff2?inline` so Vite embeds it reliably across dev/prod. The CSP adds `font-src 'self' data:` to allow the inlined font and the TypeScript shim is updated to recognise `*.woff2?inline` imports. `font-display` is switched to `block` to avoid icon fallback flashes while the font is applied.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The inline font and CSP changes consistently address the startup rendering delay without identified regressions.
Review effort: Balanced
Findings: None
What changed in this PR
Inlines the PrimeIcons font to prevent delayed or incorrect cog rendering during startup.
Changes:
- Inline the WOFF2 font and block fallback rendering.
- Permit data-URI fonts through CSP.
- Synchronize release and dependency updates with lockfiles.
| File | Description |
|---|---|
src/renderer/src/types/shims.d.ts |
Types inline WOFF2 imports. |
src/renderer/src/assets/primeicons-assets.ts |
Inlines the icon font. |
src/renderer/index.html |
Allows data-URI fonts. |
src/renderer/package.json |
Updates version and tooling. |
src/renderer/bun.lock |
Locks renderer dependencies. |
package.json |
Updates version and tooling. |
bun.lock |
Locks root dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #565.