Extract Express HTTP server adapter into oc-express-server-adapter#1522
Open
ricardo-devis-agullo wants to merge 1 commit into
Open
Extract Express HTTP server adapter into oc-express-server-adapter#1522ricardo-devis-agullo wants to merge 1 commit into
ricardo-devis-agullo wants to merge 1 commit into
Conversation
Move the in-core Express adapter into a dedicated workspace package, mirroring oc-fastify-server-adapter. oc still defaults to Express via the new package dependency, so behaviour is unchanged, while making it possible to drop Express from core later. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the in-core Express registry server adapter into a dedicated
oc-express-server-adapterpackage, mirroringoc-fastify-server-adapter.ocstill defaults to Express via the new dependency, so behavior is unchanged, while making it possible to drop Express from core later.Test plan
npm run test --workspace=oc-express-server-adapternpm run test --workspace=oc(937 passing)turbo run build --filter=oc-express-server-adapter --filter=oc