Skip to content

fix(test): exercise native code producer checks in CI - #354

Merged
vincentkoc merged 1 commit into
mainfrom
test/native-code-store-oracles
Nov 5, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
test/native-code-store-oracles

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

Fixes CI skipping native code producer Go regressions and native code-store tests accepting failed fixture reads or writes.

User Impact

No user-visible behavior changes. Linux and macOS CI now exercise the existing code-store, commit-gate and core-progress admission tests.

Why This Change Was Made

Reuse the native overlay harness for a separate code-store/command pass: code and cluster define overlapping writer helpers and require separate build tags and overlays. Preserve the cluster pass, measured-test exclusions and compile-only consumers. Check the existing code-store SQL reads, setup mutations, permissions and store handoff closes without changing fixtures or expected values.

Evidence

  • Twelve race-enabled before/after overlay cases: all 22 healthy code test/subtest cases pass in each version; broken obsolete/foreign-record reads and a failed convergence setup falsely pass before and fail after.
  • Retained-obsolete-record and failed-trigger controls fail in both versions. Reversing only the error checks reproduces the original store test file byte for byte.
  • A real failing code-admission test leaves the old harness green and fails the repaired harness. The healthy shared harness passes all 19 cluster and five code top-level tests, including consumer compilation.
  • Ten native code Python tests, module tidiness, vet, vulnerability/deadcode analysis, formatting and diff checks pass.
  • Independent P0–P3 review completed without findings. Full PR CI required before merge.
  • No production code, live archives, provider calls, deployment or releases change.

@clawsweeper

clawsweeper Bot commented Nov 5, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@vincentkoc vincentkoc self-assigned this Nov 5, 2026
@vincentkoc
vincentkoc marked this pull request as ready for review November 5, 2026 18:01
@vincentkoc
vincentkoc merged commit 50a5c9e into main Nov 5, 2026
13 of 14 checks passed
@vincentkoc
vincentkoc deleted the test/native-code-store-oracles branch November 5, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant