Repository navigation
fix(test): reject failed review-sync preservation reads - #350
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Review-sync preservation checks could pass failed SQL reads by reusing old values, comparing two default counts, or ignoring a snapshot iteration error.
User Impact
Test-only cleanup. Review syncing and archived data handling are unchanged.
Why This Change Was Made
Remove two redundant identity readbacks, JSON parsing and fallback handling; use the same PR8/R1 identities explicitly written by the fixture and always run wrong-node rejection. Check the seven remaining assertion queries and snapshot column/iteration errors. Preserve the six canonical snapshot tables, partial-response and cancellation cases, repository rejection and transactional rollback assertions. Record the cleanup in the test ledger.
Evidence