Skip to content

fix(test): reject failed review-sync preservation reads - #350

Merged
vincentkoc merged 1 commit into
mainfrom
refactor/review-sync-test-oracles
Nov 5, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
refactor/review-sync-test-oracles

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

Review-sync preservation checks could pass failed SQL reads by reusing old values, comparing two default counts, or ignoring a snapshot iteration error.

User Impact

Test-only cleanup. Review syncing and archived data handling are unchanged.

Why This Change Was Made

Remove two redundant identity readbacks, JSON parsing and fallback handling; use the same PR8/R1 identities explicitly written by the fixture and always run wrong-node rejection. Check the seven remaining assertion queries and snapshot column/iteration errors. Preserve the six canonical snapshot tables, partial-response and cancellation cases, repository rejection and transactional rollback assertions. Record the cleanup in the test ledger.

Evidence

  • Eighteen race-enabled before/after proof cases against temporary SQLite archives. Healthy cases pass in both versions; five failed-read scenarios pass before the repair and fail afterward.
  • The snapshot probe reads a real row before SQLite raises an iteration overflow, exercising the missing error check.
  • Positive-content, disabled node-validation and canonical-data-write controls all fail in both versions, confirming retained regression coverage.
  • Module tidiness, formatting, vet, vulnerability scan and deadcode checks pass.
  • Independent P0–P3 review: scoped-clean.
  • Platform CI is required before landing. Overlays are disposable, and the PR changes no production code or live archives. No releases.

@clawsweeper

clawsweeper Bot commented Nov 5, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@vincentkoc vincentkoc self-assigned this Nov 5, 2026
@vincentkoc
vincentkoc marked this pull request as ready for review November 5, 2026 16:37
@vincentkoc
vincentkoc merged commit 6dbb82c into main Nov 5, 2026
14 checks passed
@vincentkoc
vincentkoc deleted the refactor/review-sync-test-oracles branch November 5, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant