Skip to content

fix(test): fail owner-purge assertions on SQL errors - #348

Merged
vincentkoc merged 1 commit into
mainfrom
test/owner-purge-query-errors
Nov 5, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
test/owner-purge-query-errors

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

Owner-purge tests could report success when assertion queries failed and left zero counts or equal empty evidence strings.

User Impact

Test-only change. Purge behavior and archived data handling are unchanged.

Why This Change Was Made

Check all 20 previously ignored assertion-query results before comparing values. Preserve every fixture, SQL literal, mutation and expected value, including the outer purge errors used by refusal tests. Record the repair in the test cleanup ledger.

Evidence

  • Fourteen race-enabled Go overlay runs: baseline and fixed healthy suites each pass all 24 parent/subtest cases. Five broken-read scenarios pass before the repair and fail on SQL errors afterward; a positive-count control fails in both versions.
  • Verified that unwinding the 20 error guards reproduces the original test file byte for byte.
  • Module tidiness, formatting, vet, vulnerability scan and deadcode checks pass.
  • Independent P0–P3 review: scoped-clean.
  • Platform CI is required before landing. All local SQLite archives and overlays are disposable test fixtures. No releases.

@vincentkoc vincentkoc self-assigned this Nov 5, 2026
@clawsweeper

clawsweeper Bot commented Nov 5, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@vincentkoc
vincentkoc marked this pull request as ready for review November 5, 2026 16:16
@vincentkoc
vincentkoc merged commit 0833859 into main Nov 5, 2026
16 checks passed
@vincentkoc
vincentkoc deleted the test/owner-purge-query-errors branch November 5, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant