Skip to content

fix(test): fail native bridge assertions on SQL errors - #347

Merged
vincentkoc merged 1 commit into
mainfrom
test/native-bridge-query-errors
Nov 5, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
test/native-bridge-query-errors

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

What Problem This Solves

Native bridge assertions accepted default counts or equal empty timestamps after a failed SQL read.

User Impact

No user-visible change. Broken assertion queries fail the test instead of silently passing preview/no-write or idempotency checks.

Why This Change Was Made

Check all six assertion-query results before comparing values, and pass the active subtest to the shared empty-table helper. Preserve SQL literals, SQLite fixtures, import mutations, preview/no-write, idempotency, writer and large-packet assertions. Record the cleanup in the ledger; production code is unchanged.

Evidence

  • Sixteen race-enabled Go overlay runs verified healthy cases and broken-query probes. Empty-table, timestamp and large-preview read failures passed before the fix and failed afterward; the positive convergence assertion rejected broken reads in both versions.
  • A subtest-only broken query now fails the correct child without parent FailNow misuse. All temporary overlays were removed.
  • All 19 native overlay tests passed; exporter and reader compiled. Dependency tidiness, formatting, vet, vulnerability and dead-code checks passed. Independent P0–P3 review found no actionable defects.
  • PR CI supplies the full platform matrix. No providers, live archives, deployments or releases.

@clawsweeper

clawsweeper Bot commented Nov 5, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@vincentkoc vincentkoc self-assigned this Nov 5, 2026
@vincentkoc
vincentkoc marked this pull request as ready for review November 5, 2026 15:50
@vincentkoc
vincentkoc merged commit 10a6157 into main Nov 5, 2026
14 checks passed
@vincentkoc
vincentkoc deleted the test/native-bridge-query-errors branch November 5, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant