Skip to content

refactor(test): share overflowing detail model fixture #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincentkoc merged 1 commit into from
Nov 5, 2026
Merged

refactor(test): share overflowing detail model fixture #330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 14 additions & 89 deletions internal/cli/tui_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4535,11 +4535,7 @@ func TestTUIApplyClusterFiltersPreservesClusterSource(t *testing.T) {
}
}

// TestTUIDetailViewportScrollsWithKeyboard guards the regression where the
// detail pane could not be scrolled by any input. detailView.SetContent was
// only called from renderDetail (a View() value-receiver copy), so the
// persistent viewport never had content and LineUp/LineDown/wheel were no-ops.
func TestTUIDetailViewportScrollsWithKeyboard(t *testing.T) {
func newOverflowingDetailTestModel() clusterBrowserModel {
model := newClusterBrowserModel(context.Background(), nil, 0, clusterBrowserPayload{
Repository: "openclaw/openclaw",
Sort: "recent",
Expand All @@ -4561,6 +4557,15 @@ func TestTUIDetailViewportScrollsWithKeyboard(t *testing.T) {
}
model.hasDetail = true
model.sortMembers()
return model
}

// TestTUIDetailViewportScrollsWithKeyboard guards the regression where the
// detail pane could not be scrolled by any input. detailView.SetContent was
// only called from renderDetail (a View() value-receiver copy), so the
// persistent viewport never had content and LineUp/LineDown/wheel were no-ops.
func TestTUIDetailViewportScrollsWithKeyboard(t *testing.T) {
model := newOverflowingDetailTestModel()

// Small terminal so detail content overflows its viewport, then focus the
// detail pane (clusters -> members -> detail).
Expand Down Expand Up @@ -4592,27 +4597,7 @@ func TestTUIDetailViewportScrollsWithKeyboard(t *testing.T) {
}

func TestTUISyncComponentsClampsDetailViewportAfterResize(t *testing.T) {
model := newClusterBrowserModel(context.Background(), nil, 0, clusterBrowserPayload{
Repository: "openclaw/openclaw",
Sort: "recent",
Clusters: []store.ClusterSummary{
{ID: 1, Status: "active", MemberCount: 1, UpdatedAt: "2026-04-27T00:00:00Z"},
},
})
model.detail = store.ClusterDetail{
Cluster: model.payload.Clusters[0],
Members: []store.ClusterMemberDetail{
{
Thread: store.Thread{
ID: 10, Number: 10, Kind: "issue", State: "open",
Title: strings.Repeat("a long detail title that wraps many times ", 40),
},
BodySnippet: strings.Repeat("body line\n", 60),
},
},
}
model.hasDetail = true
model.sortMembers()
model := newOverflowingDetailTestModel()
model.width = 120
model.height = 16
model.syncComponents()
Expand All @@ -4632,27 +4617,7 @@ func TestTUISyncComponentsClampsDetailViewportAfterResize(t *testing.T) {
}

func TestTUISyncComponentsResetsDetailViewportWhenContentModeChanges(t *testing.T) {
model := newClusterBrowserModel(context.Background(), nil, 0, clusterBrowserPayload{
Repository: "openclaw/openclaw",
Sort: "recent",
Clusters: []store.ClusterSummary{
{ID: 1, Status: "active", MemberCount: 1, UpdatedAt: "2026-04-27T00:00:00Z"},
},
})
model.detail = store.ClusterDetail{
Cluster: model.payload.Clusters[0],
Members: []store.ClusterMemberDetail{
{
Thread: store.Thread{
ID: 10, Number: 10, Kind: "issue", State: "open",
Title: strings.Repeat("a long detail title that wraps many times ", 40),
},
BodySnippet: strings.Repeat("body line\n", 60),
},
},
}
model.hasDetail = true
model.sortMembers()
model := newOverflowingDetailTestModel()
model.width = 120
model.height = 16
model.syncComponents()
Expand All @@ -4677,27 +4642,7 @@ func TestTUISyncComponentsResetsDetailViewportWhenContentModeChanges(t *testing.
}

func TestTUIUpdateSyncsDetailViewportAfterMenuKey(t *testing.T) {
model := newClusterBrowserModel(context.Background(), nil, 0, clusterBrowserPayload{
Repository: "openclaw/openclaw",
Sort: "recent",
Clusters: []store.ClusterSummary{
{ID: 1, Status: "active", MemberCount: 1, UpdatedAt: "2026-04-27T00:00:00Z"},
},
})
model.detail = store.ClusterDetail{
Cluster: model.payload.Clusters[0],
Members: []store.ClusterMemberDetail{
{
Thread: store.Thread{
ID: 10, Number: 10, Kind: "issue", State: "open",
Title: strings.Repeat("a long detail title that wraps many times ", 40),
},
BodySnippet: strings.Repeat("body line\n", 60),
},
},
}
model.hasDetail = true
model.sortMembers()
model := newOverflowingDetailTestModel()
model.width = 120
model.height = 16
model.syncComponents()
Expand All @@ -4724,27 +4669,7 @@ func TestTUIUpdateSyncsDetailViewportAfterMenuKey(t *testing.T) {

func TestTUIUpdateSyncsDetailViewportAfterSearchJumpShortcuts(t *testing.T) {
newModel := func() clusterBrowserModel {
model := newClusterBrowserModel(context.Background(), nil, 0, clusterBrowserPayload{
Repository: "openclaw/openclaw",
Sort: "recent",
Clusters: []store.ClusterSummary{
{ID: 1, Status: "active", MemberCount: 1, UpdatedAt: "2026-04-27T00:00:00Z"},
},
})
model.detail = store.ClusterDetail{
Cluster: model.payload.Clusters[0],
Members: []store.ClusterMemberDetail{
{
Thread: store.Thread{
ID: 10, Number: 10, Kind: "issue", State: "open",
Title: strings.Repeat("a long detail title that wraps many times ", 40),
},
BodySnippet: strings.Repeat("body line\n", 60),
},
},
}
model.hasDetail = true
model.sortMembers()
model := newOverflowingDetailTestModel()
model.width = 120
model.height = 8
model.showHelp = true
Expand Down
Loading