Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Expose selected destination state before negotiation so tracing consumers can compare push paths without another lookup.
e0e9b7e to
8fe89f6
Compare
💡 Codex ReviewLines 228 to 229 in e0e9b7e When a URL containing credentials receives an absolute same-host redirect whose ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
tldr: Record advertised destination state before push negotiation so timings can distinguish absent and existing refs.
The bounded Trace2 event classifies selected branch refs as absent or existing, identifies other and mixed selections, and records whether an absent advertisement supports explicit-haves. It includes no ref names or object IDs and describes the advertisement, not the push result.
Testing
Exercised local pushes with ordinary and explicit-haves advertisements, including new refs, forced updates, up-to-date refs, and mixed selections.
What Could Go Wrong
Hidden refs can appear absent. Consumers must verify the advertisement guarantees before interpreting absence as branch creation and treat missing or ambiguous evidence as unknown.