Skip to content

fix: remove remediation patch size limit - #329

Merged
mldangelo-oai merged 2 commits into
mainfrom
mdangelo/codex/remove-remediation-patch-cap-20260810
Aug 10, 2026
Merged

fix: remove remediation patch size limit#329
mldangelo-oai merged 2 commits into
mainfrom
mdangelo/codex/remove-remediation-patch-cap-20260810

Conversation

@mldangelo-oai

Copy link
Copy Markdown
Collaborator

Remove the arbitrary 2 MiB ceiling on reviewed remediation patches.

Patch digest verification already reads files in bounded chunks, and finding previews already retain only their existing 16 KB preview. Keep both behaviors, including digest-mismatch rejection, while allowing larger valid patches.

Validation:

  • Full SDK suite: 979 passed, 11 expected skips.
  • New regression accepts a patch larger than 2 MiB, verifies its streamed digest, retains a bounded preview, and rejects an incorrect digest.
  • TypeScript, Python syntax/lint, and focused Prettier checks passed.

@mldangelo-oai
mldangelo-oai requested a review from ianw-oai August 10, 2026 15:30
@github-actions github-actions Bot added the bug Something isn't working label Aug 10, 2026
@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 6310bd9416

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 6310bd9416

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 6310bd9416

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@mldangelo-oai

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7062184d4c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread sdk/typescript/_bundled_plugin/scripts/workbench_db.py
Comment thread sdk/typescript/_bundled_plugin/scripts/workbench_db.py
@chatgpt-codex-connector

Copy link
Copy Markdown

Security review completed. No security issues were found in this pull request.

Reviewed commit: 7062184d4c

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@mldangelo-oai
mldangelo-oai merged commit 959f125 into main Aug 10, 2026
16 checks passed
@mldangelo-oai
mldangelo-oai deleted the mdangelo/codex/remove-remediation-patch-cap-20260810 branch August 10, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants