Skip to content

[BUGFIX] Magic Items are now returned by the Search endpoint #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calumbell merged 1 commit into from
Sep 27, 2026
+4 −1
Merged

[BUGFIX] Magic Items are now returned by the Search endpoint #975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion search/management/commands/buildindex.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def load_v1_content(self, model):

def load_v2_content(self, model):
results = []
standard_v2_models = ['Item','Spell','Creature','CharacterClass','Species','Feat','Background','Environment', 'Rule']
standard_v2_models = ['Item','Spell','Creature','CharacterClass','Species','Feat','Background','Environment', 'Rule', 'MagicItem']

if model.__name__ in standard_v2_models:
for o in model.objects.all():
Expand Down Expand Up @@ -167,6 +167,7 @@ def handle(self, *args, **options):
self.load_content(v2.Background,"v2")
self.load_content(v2.Environment,"v2")
self.load_content(v2.Rule, "v2")
self.load_content(v2.MagicItem, "v2")

# Take the content table's current data and load it into the index.
self.load_index()
Expand Down
2 changes: 2 additions & 0 deletions search/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ def get_object(self, obj):
if obj.schema_version == 'v2':
if obj.object_model == 'Item':
result_detail = v2.Item.objects.get(pk=obj.object_pk)
if obj.object_model == 'MagicItem':
result_detail = v2.MagicItem.objects.get(pk=obj.object_pk)
if obj.object_model == 'Creature':
result_detail = v2.Creature.objects.get(pk=obj.object_pk)
if obj.object_model == 'Spell':
Expand Down
Loading