Make WeaverLiveCheck tolerate slow Weaver startup - #5498
Open
saisharan0103 wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5176.
WeaverLiveCheck was using a fixed urllib3 Retry budget while waiting for the Weaver admin /health endpoint. On slower PyPy jobs, the admin listener can still be starting when those retries are exhausted, producing repeated localhost connection-refused warnings and failing the test even when the Weaver subprocess has not failed.
This change adds a configurable startup timeout and replaces the Retry-based health probe with an explicit monotonic-deadline polling loop using short per-request timeouts. The helper still checks whether the Weaver subprocess has exited so real startup failures raise RuntimeError quickly with logs, while slow successful startups can continue until the deadline.
Focused tests cover delayed readiness succeeding and exited subprocesses still raising RuntimeError by mocking the health request and process poll paths.
ruff check tests/opentelemetry-test-utils/src/opentelemetry/test/weaver_live_check.py tests/opentelemetry-test-utils/tests/test_weaver_live_check.pyreports no new findings on the changed files.Ran
pytest -xlocally with no new failures.