Repository navigation
fix: use a unique tie-breaker for learning path pagination - #72
Closed
lifeofgurpreet wants to merge 1 commit into
Closed
lifeofgurpreet wants to merge 1 commit into
lifeofgurpreet wants to merge 1 commit into
Conversation
Preserve enrollment-date ordering and visibility while ordering equal and NULL dates by the immutable path ID. Cover staff/non-staff page membership and require a unique ORM ordering term, so incidental SQLite row order cannot hide the regression.
Author
|
Same-environment comparison confirms the broad-suite failures are inherited: unmodified main51d927f has14PASS/3audit-factory DoesNotExist failures; the proposed head dc6c08f has16PASS/the same3failures. The two new pagination tests and existing image replacement pass; removing the unique ordering term fails both new tests. No full-suite pass claimed. |
Member
|
Ordering is already implemented in #71. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Equal enrollment dates and the NULL dates of non-enrolled paths currently have no unique ordering term. Add the immutable path
idafter descending enrollment date / NULLs last, preserving visibility and the existing leading sort order while giving paginated lists a total order.The focused tests cover staff/non-staff visibility, equal dates, NULL dates and page membership. They also require a unique term in the actual ORM ordering: small SQLite fixtures can coincidentally return ID order even when the fix is absent. Removing the tie-breaker fails both tests.
Validation (Python3.12 / Django5.2.13, native package/models/migrations): the two new tests and the existing image-replacement test pass. A broader models run has three existing audit-factory
DoesNotExistfailures; it is not claimed as green. Ruff F checks, diff checks and scoped UBS (0 critical / 0 warning / 59 info) pass. No CI wait or runtime/tenant acceptance is claimed.