hotfix: Gracefully stop interrupted native app commands by omry · Pull Request #319 · omry/reploy

omry · 2026-11-01T22:24:45Z

Let interrupted native applications finish bounded cleanup and publish output before exact-container forced removal. Preserve existing live-run recovery, stdin/EOF, argv, exit status and public mapped guards. Add a real packaged-CLI six-case regression to Linux CI and retain the separate RDA consumer request.

gitar-bot · 2026-11-01T22:25:57Z

Code Review ✅ Approved

🟡 Medium risk · Native-command interruption now waits for a bounded engine stop before forced removal, which could delay CLI exit when the engine is unresponsive.

Lets interrupted native applications finish bounded cleanup and publish output before exact-container forced removal, preserving live-run recovery, stdin/EOF handling, argv, exit status, and public mapped guards. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

_{For more verification details, comment gitar display:verbose.}

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

`Auto-apply`	`Compact`
`gitar auto-apply:on`	`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source}

omry · 2026-11-01T22:29:47Z

PR-cycle state — maintained automatically. Do not edit by hand.

Mechanical PR-cycle state (JSON)

{
  "approval": {
    "candidate_revision_fingerprint": "sha256:483e92b94089171521bff9585fc31476823a09ba04efcdcfcbe63b625f6863f6",
    "evidence": {
      "attestations": [],
      "candidate_revision_fingerprint": "sha256:483e92b94089171521bff9585fc31476823a09ba04efcdcfcbe63b625f6863f6",
      "check_conclusions": [
        {
          "conclusion": "SUCCESS",
          "name": "Bash native evidence checks",
          "run_id": 125002967120
        },
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 124999104007
        },
        {
          "conclusion": "SUCCESS",
          "name": "Linux CI checks",
          "run_id": 124999100655
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-amd64)",
          "run_id": 124999100584
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-arm64)",
          "run_id": 124999100690
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-amd64)",
          "run_id": 124999100571
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-arm64)",
          "run_id": 124999100562
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-amd64)",
          "run_id": 124999100603
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-arm64)",
          "run_id": 124999100594
        }
      ],
      "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "finding_dispositions_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "operation_identity": "sha256:43c38351e664a799997643b84ced470ca73f25f9ce186deb19086dd022e6837a",
      "review_request": {
        "body_digest": "sha256:28fa18dd0696d2c45e060d271aa7909b737fa6abebd78567f932ff9e9a482579",
        "id": 6564883561
      },
      "review_result": {
        "body_digest": "sha256:574b1b6baff4d565ca2d94a1372b28b780d74f958b8ca76a223d11a77e726ca5",
        "id": 6564895442
      }
    },
    "evidence_fingerprint": "sha256:28198cfd8619fbf135049eb3214915f9823d4fdab756c9ba7ce7d71a189df86d",
    "head_sha": "fe4c131cf5eb00dc267009dd99935480febde1bf",
    "operation_identity": "sha256:43c38351e664a799997643b84ced470ca73f25f9ce186deb19086dd022e6837a",
    "review_request_id": 6564883561,
    "review_result_id": 6564895442,
    "status": "approved-evidence-recorded"
  },
  "candidate_revision_fingerprint": "sha256:483e92b94089171521bff9585fc31476823a09ba04efcdcfcbe63b625f6863f6",
  "check_conclusions": [
    {
      "conclusion": "SUCCESS",
      "name": "Bash native evidence checks",
      "run_id": 125002967120
    },
    {
      "conclusion": "SUCCESS",
      "name": "Gitar",
      "run_id": 124999104007
    },
    {
      "conclusion": "SUCCESS",
      "name": "Linux CI checks",
      "run_id": 124999100655
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (darwin-amd64)",
      "run_id": 124999100584
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (darwin-arm64)",
      "run_id": 124999100690
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (linux-amd64)",
      "run_id": 124999100571
    },
    {
      "conclusion": "SUCCESS",
      "name": "Target smoke (linux-arm64)",
      "run_id": 124999100562
    },
    {
      "conclusion": "SUCCESS",
      "name": "Windows host smoke (windows-amd64)",
      "run_id": 124999100603
    },
    {
      "conclusion": "SUCCESS",
      "name": "Windows host smoke (windows-arm64)",
      "run_id": 124999100594
    }
  ],
  "check_observations": [
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "Bash native evidence checks",
          "run_id": 125002967120,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41356999544/job/125002967120"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Gitar",
          "run_id": 124999104007,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/runs/124999104007"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Linux CI checks",
          "run_id": 124999100655,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41356999544/job/124999100655"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-amd64)",
          "run_id": 124999100584,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41356999544/job/124999100584"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (darwin-arm64)",
          "run_id": 124999100690,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41356999544/job/124999100690"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-amd64)",
          "run_id": 124999100571,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41356999544/job/124999100571"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Target smoke (linux-arm64)",
          "run_id": 124999100562,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41356999544/job/124999100562"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-amd64)",
          "run_id": 124999100603,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41356999544/job/124999100603"
        },
        {
          "conclusion": "SUCCESS",
          "name": "Windows host smoke (windows-arm64)",
          "run_id": 124999100594,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/omry/reploy/actions/runs/41356999544/job/124999100594"
        }
      ],
      "head_sha": "fe4c131cf5eb00dc267009dd99935480febde1bf",
      "id": "sha256:e85d60eaaf6da383ec61d5b1f78ae369a9a43cfa0b082730cbc4efc93a1fdde4",
      "required_checks": [
        "Bash native evidence checks",
        "Gitar",
        "Linux CI checks",
        "Target smoke (darwin-amd64)",
        "Target smoke (darwin-arm64)",
        "Target smoke (linux-amd64)",
        "Target smoke (linux-arm64)",
        "Windows host smoke (windows-amd64)",
        "Windows host smoke (windows-arm64)"
      ],
      "status": "success"
    }
  ],
  "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
  "delivery_deferrals": [],
  "findings": [],
  "pr": {
    "base_ref": "main",
    "base_sha": "833e2d5b4c89a70f49f5ded3edb1190ba7b88a18",
    "body_digest": "sha256:9c80780e341b9f548bec89df775a55f585aa0afe009f39bab969524d36f186bf",
    "body_identity_version": 2,
    "diff_digest": "sha256:2945b7c73dd4651703565332b6b8f094a00ee1c58f5be4e4bca968b1483a63f3",
    "head_ref": "pr319",
    "head_sha": "fe4c131cf5eb00dc267009dd99935480febde1bf",
    "pr": 319,
    "repository": "omry/reploy",
    "scope_authority": [],
    "title_digest": "sha256:4c3edb4d204ee3a931b120e7fc106b17b7bf106fb3e1469e9b9dcf810a80f2fe"
  },
  "record_version": 4,
  "review_observations": [],
  "review_requests": [
    {
      "base_established_at": "2026-11-01T22:24:45Z",
      "base_ref": "main",
      "base_sha": "833e2d5b4c89a70f49f5ded3edb1190ba7b88a18",
      "body_digest": "sha256:28fa18dd0696d2c45e060d271aa7909b737fa6abebd78567f932ff9e9a482579",
      "created_at": "2026-11-01T22:33:33Z",
      "head_sha": "fe4c131cf5eb00dc267009dd99935480febde1bf",
      "id": 6564883561,
      "kind": "regular-review"
    }
  ],
  "review_results": [
    {
      "base_ref": "main",
      "base_sha": "833e2d5b4c89a70f49f5ded3edb1190ba7b88a18",
      "body_digest": "sha256:574b1b6baff4d565ca2d94a1372b28b780d74f958b8ca76a223d11a77e726ca5",
      "commit_id": "fe4c131cf5eb00dc267009dd99935480febde1bf",
      "id": 6564895442,
      "inline_message_ids": [],
      "request_comment_id": 6564883561,
      "result_kind": "clean",
      "status": "result",
      "submitted_at": "2026-11-01T22:34:39Z",
      "unresolved_thread_ids": []
    }
  ],
  "revision_fingerprint": "sha256:483e92b94089171521bff9585fc31476823a09ba04efcdcfcbe63b625f6863f6",
  "rounds": [
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:2945b7c73dd4651703565332b6b8f094a00ee1c58f5be4e4bca968b1483a63f3",
      "finding_ids": [],
      "invariants": [
        "Native-only bounded graceful stop before exact-container forced removal; output finalization, child cleanup, piped stdin/EOF, argv and application status preserved",
        "Bound engine endpoint, live-run recovery ownership and public mapped activation guards preserved"
      ],
      "outcome": "clean",
      "proposed_fix_paths": [],
      "resulting_head": "fe4c131cf5eb00dc267009dd99935480febde1bf",
      "review_observation_id": null,
      "review_request_id": 6564883561,
      "review_result_id": 6564895442,
      "reviewed_head": "fe4c131cf5eb00dc267009dd99935480febde1bf",
      "root_cause": null,
      "round": 1,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    }
  ],
  "schema": "awd:swe:pr-cycle-state",
  "version": 2
}

chatgpt-codex-connector · 2026-11-01T22:30:38Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-01T22:34:40.537876Z	`fe4c131`	Manual request
🔒 Security Review	✅ Completed 2026-11-01T22:32:31.034998Z	`fe4c131`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

omry · 2026-11-01T22:33:33Z

@codex review

Exact head: fe4c131

chatgpt-codex-connector · 2026-11-01T22:34:39Z

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: fe4c131cf5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

omry marked this pull request as ready for review November 1, 2026 22:30

omry added the approved PR reviewed and approved label Nov 1, 2026

Navigation Menu

Repository navigation

hotfix: Gracefully stop interrupted native app commands - #319

hotfix: Gracefully stop interrupted native app commands#319
omry wants to merge 1 commit into
mainfrom
pr319

omry commented Nov 1, 2026

Uh oh!

gitar-bot Bot commented Nov 1, 2026 •

edited

Loading

Uh oh!

omry commented Nov 1, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot commented Nov 1, 2026 •

edited

Loading

Uh oh!

omry commented Nov 1, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 1, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

omry commented Nov 1, 2026

Uh oh!

gitar-bot Bot commented Nov 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

omry commented Nov 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Nov 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

omry commented Nov 1, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 1, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

gitar-bot Bot commented Nov 1, 2026 •

edited

Loading

omry commented Nov 1, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Nov 1, 2026 •

edited

Loading