Repository navigation
release v0.7.4 - #164
release v0.7.4#164
Conversation
✅ Verdict:
|
| Findings | Count |
|---|---|
| 🔴 must-fix | 0 |
| 🟠 should-fix | 0 |
| 🟡 may-fix | 0 |
| 🔵 nit | 0 |
📋 Review
What this PR does: Release-prep PR for dsh-advisor 0.7.4: it adds the ## [0.7.4] - 2026-11-17 CHANGELOG section covering the two merges since 0.7.3 (#163 zh README parity, #162 image-placeholder fix) and moves package.json to version 0.7.4. Merging it is the trigger for the Release workflow, which typechecks, builds and tests, publishes [email protected] to npm, then creates tag v0.7.4 and the GitHub Release from that same CHANGELOG section. The change is metadata-only; no runtime source files are touched.
Findings
none
Revalidated findings
none
Linked-issue AC
none — the PR links no issue (issues: [] in the supplied context), so there are no acceptance criteria to map.
✅ Verified
- Review document at head [REDACTED] records verdict ship it at 100% (mergeable) with must-fix=0, should-fix=0, may-fix=0, nit=0, and an empty prior-finding revalidation table (nothing to re-check).
- Static read of the PR head: package.json declares "version": "0.7.4", and CHANGELOG.md opens with a matching ## [0.7.4] - 2026-11-17 section listing the two merge commits quoted in the PR body.
- Static read: no other tracked manifest claims a different version — 0.7.3 survives only as the previous CHANGELOG section heading, and pnpm-lock.yaml importers do not record the root package version, so no lockfile drift is expected from this bump.
- Static read: .github/workflows/release.yml cross-checks the PR title (release v<version>) against package.json before publishing, runs pnpm run typecheck, build and test, asserts lib/index.js and cordis.patch.yml are in the packed tarball, and refuses to create an empty Release when the CHANGELOG section is missing — all fail-closed guards, not silent paths.
- ❓ No CI log, pnpm typecheck/build/test output, or resulting tag/publish state is attached to the review document, so those gates are unconfirmed here and will only be exercised by the post-merge Release workflow.
- ❓ The PR title itself is not part of the supplied context; release.yml requires it to be exactly release v0.7.4, otherwise the release job fails its version cross-check (visible failure, no bad publish).
🗑️ Considered & rejected
- Version/tag mismatch risk — 0.7.4 is a formal semver release (no prerelease suffix), so npm publish takes the default latest dist-tag and the tag step creates v0.7.4; the workflow's title-vs-package.json cross-check rejects drift before any publish. Dismissed.
- Empty or stale GitHub Release body — the ## [0.7.4] section exists in CHANGELOG.md and release.yml aborts rather than creating an empty Release if extraction produces nothing. Dismissed.
- PR body drifting from the changelog — the body is the extracted 0.7.4 section plus the single merge-instruction line that release-prep.yml appends, which is exactly the documented contract. Dismissed.
- Leftover 0.7.3 references — a repo-wide search finds 0.7.3 only as the historical CHANGELOG heading; no manifest, source or config still pins the old version. Dismissed.
- Missing lockfile sync — the bump touches only package.json and CHANGELOG.md; pnpm's lockfile importer entries carry no root version, so there is nothing to re-resolve. Dismissed.
- Unrelated changes smuggled into the release — the reviewed scope is release metadata only (version field plus changelog entry for the two already-merged PRs); no source, workflow or dependency edits. Dismissed.
🛠️ Plan to fix
Expand fix plan
none — zero findings remain, so there is no fix plan. The only remaining action is operational: merge, then confirm the Release run publishes `[email protected]`, pushes tag `v0.7.4`, and attaches a non-empty Release body.Review 1 · commit afd40f2
[0.7.4] - 2026-11-17
Merging this PR tags v0.7.4 and publishes [email protected] via the Release workflow.