Skip to content

release v0.7.3 - #158

Closed
btspoony wants to merge 1 commit into
mainfrom
release/v0.7.3
Closed

btspoony wants to merge 1 commit into
mainfrom
release/v0.7.3

Conversation

@btspoony

Copy link
Copy Markdown
Member

[0.7.3] - 2026-11-17

Merging this PR tags v0.7.3 and publishes [email protected] via the Release workflow.

@btspoony btspoony added the release Release PRs label Nov 17, 2026
@m-inspector

m-inspector Bot commented Nov 17, 2026

Copy link
Copy Markdown

✅ Verdict: ship it · Score 94% (mergeable)

Findings Count
🔴 must-fix 0
🟠 should-fix 0
🟡 may-fix 1
🔵 nit 0

📋 Review

What this PR does: Release-prep PR for dsh-advisor 0.7.3: it adds the ## [0.7.3] - 2026-11-17 section to CHANGELOG.md containing one bullet for the #157 word-boundary-truncation merge, with package.json at version 0.7.3. Per the PR body, merging tags v0.7.3 and publishes [email protected] through the Release workflow. The reviewed change is release metadata only, with a single may-fix note about the formal version conflicting with the documented alpha-only release policy.

Findings

🟡 CHANGELOG declares a formal 0.7.3 release the documented release policy forbids

  • Evidence: - Evidence: CHANGELOG.md:5 — the added section header is ## [0.7.3] - 2026-11-17 with the single bullet - 97c12eb Merge pull request #157 from omdsh-dev/fix/word-boundary-truncation at CHANGELOG.md:7; version 0.7.3 in package.json:3 matches it.\n- Evidence: docs/release.md:30 — maintainer-owned current policy: "发布流程恢复正常之前,一律使用 alpha 预发布版本发版(显式填写如 0.2.0-alpha.1),禁止发布正式版本;何时恢复正常由维护者明确宣布" (use alpha prereleases only; formal releases forbidden until the maintainer explicitly announces restoration). AGENTS.md repeats the same "Current policy" callout, and tests/prepare-release.test.ts:424 calls it "the alpha-only release rule". docs/release.md:36 states a formal version publishes to latest.\n- Impact: merging this release PR tags and publishes [email protected] as the latest dist-tag, contrary to the policy text that still governs release dispatch; every npm install dsh-advisor resolves to the release the docs say must not be made. The section is also the body of both the release PR and the GitHub Release, so the contradiction is published, not just committed.\n- Caveat (why this is may-fix, not should-fix): the same drift already exists in prior entries — CHANGELOG.md:9 (0.7.2), :14 (0.7.1), :19 (0.7.0) are all formal versions — so the stale text is plausibly the policy documents rather than this diff, and the fix site (package.json/dispatch input or docs/release.md §3) is outside this seat's file scope. The generated section itself conforms exactly to scripts/prepare-release.mjs updateChangelog (header, blank line, - <sha> <subject> bullets, blank separator, prior sections untouched), and the extraction anchors in .github/workflows/release-prep.yml / release.yml match it.\n- Effort: XS — either dispatch with an explicit X.Y.Z-alpha.N version and regenerate this section, or drop the alpha-only clause from docs/release.md:30 / AGENTS.md and state formal releases are current practice.\n- Risk…
  • Location: CHANGELOG.md:5-7
  • Category: docs
  • Merge class: may-fix
Revalidated findings

none

Linked-issue AC

none — the PR body lists no linked issues (issues: []), so there are no acceptance criteria to evaluate.

✅ Verified

- CHANGELOG.md:5-7 — added header ## [0.7.3] - 2026-11-17 plus one - &lt;sha> &lt;subject> bullet, matching the updateChangelog shape in scripts/prepare-release.mjs (header, blank line, bullets, blank separator, prior sections untouched).
- package.json:3 — "version": "0.7.3" agrees with the CHANGELOG section header.
- docs/release.md:30 — the maintainer-owned current policy still prohibits formal releases until explicitly restored; docs/release.md:36 states a formal X.Y.Z publishes to latest.
- Drift predates this diff: CHANGELOG.md:9 (0.7.2), :14 (0.7.1), and :19 (0.7.0) are all formal versions.
- AGENTS.md repeats the alpha-only callout, and a grep of tests/prepare-release.test.ts:424 finds the rule named "the alpha-only release rule".
- Release section-extraction anchors in .github/workflows/release-prep.yml and release.yml match the new header.
- ❓ Completeness of the 0.7.3 section against the v0.7.2..v0.7.3 first-parent commit range (e.g. whether PRs #154–#156 belong) — the review clone is shallow at befc7fd with no tag refs, so this was declared unscanned.

🗑️ Considered & rejected

- Malformed or hand-edited CHANGELOG section — rejected: the generated header, blank lines, bullet format, and untouched prior sections conform exactly to the scripts/prepare-release.mjs updateChangelog template.
- Broken release section extraction — rejected: the anchors used by .github/workflows/release-prep.yml and release.yml match the ## [0.7.3] header, so the release PR body and GitHub Release can be built from it.
- Version/header mismatch between package.json and the CHANGELOG — rejected: both are 0.7.3.

🛠️ Plan to fix

Expand fix plan
1. **Resolve the policy conflict (maintainer call).** Decide whether formal releases have resumed. The evidence points to stale docs rather than a malformed diff, but only the maintainer can settle it; state the decision in the PR thread.
2. **If formal releases are now allowed:** remove or rewrite the alpha-only prohibition in `docs/release.md` §3 (~line 30) and the matching "Current policy" callout in `AGENTS.md`; update `tests/prepare-release.test.ts:424` if it asserts the prohibition; leave the 0.7.3 CHANGELOG section and `package.json` version as-is.
3. **If the alpha-only policy still stands:** re-run Release prep with an explicit `0.7.3-alpha.1` version. Replace the `## [0.7.3] - 2026-11-17` section with the generated `0.7.3-alpha.1` section, set `package.json` to `0.7.3-alpha.1`, and let the PR body regenerate from that section. Do not tag or publish `v0.7.3`.
4. **Guard against a half-published state:** confirm no `v0.7.3` tag or npm version exists; if one does, do not attempt to republish the same version — bump to a new one instead (npm versions are immutable).
5. **Verification gates:** run `pnpm test tests/prepare-release.test.ts`; exercise the release-prep section extraction against the new CHANGELOG section; and after merge/publish confirm the intended dist-tag (`latest` only for a formal release, `alpha` for `0.7.3-alpha.1`) via `npm view dsh-advisor dist-tags`.
6. **Scope note:** the CHANGELOG section itself is already correct for the 0.7.3 version it declares, so no edit to `CHANGELOG.md:5-7` is needed unless step 3 changes the chosen version.

Review 1 · commit befc7fd

@m-inspector m-inspector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mstar-inspector line comments · round 1 · befc7fd

Comment thread CHANGELOG.md

## [0.7.3] - 2026-11-17

- 97c12eb Merge pull request #157 from omdsh-dev/fix/word-boundary-truncation

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG declares a formal 0.7.3 release the documented release policy forbids · 🟡 may-fix

  • Evidence: CHANGELOG.md:5 — the added section header is ## [0.7.3] - 2026-11-17 with the single bullet - 97c12eb Merge pull request #157 from omdsh-dev/fix/word-boundary-truncation at CHANGELOG.md:7; version 0.7.3 in package.json:3 matches it.\n- Evidence: docs/release.md:30 — maintainer-owned current policy: "发布流程恢复正常之前,一律使用 alpha 预发布版本发版(显式填写如 0.2.0-alpha.1),禁止发布正式版本;何时恢复正常由维护者明确宣布" (use alpha prereleases only; formal releases forbidden until the maintainer explicitly announces restoration). AGENTS.md repeats the same "Current policy" callout, and tests/prepare-release.test.ts:424 calls it "the alpha-only release rule". docs/release.md:36 states a formal version publishes to latest.\n- Impact: merging this release PR tags and publishes [email protected] as the latest dist-tag, contrary to the policy text that still governs release dispatch; every npm install dsh-advisor resolves to the release the docs say must not be made. The section is also the body of both the release PR and the GitHub Release, so the contradiction is published, not just committed.\n- Caveat (why this is may-fix, not should-fix): the same drift already exists in prior entries — CHANGELOG.md:9 (0.7.2), :14 (0.7.1), :19 (0.7.0) are all formal versions — so the stale text is plausibly the policy documents rather than this diff, and the fix site (package.json/dispatch input or docs/release.md §3) is outside this seat's file scope. The generated section itself conforms exactly to scripts/prepare-release.mjs updateChangelog (header, blank line, - <sha> <subject> bullets, blank separator, prior sections untouched), and the extraction anchors in .github/workflows/release-prep.yml / release.yml match it.\n- Effort: XS — either dispatch with an explicit X.Y.Z-alpha.N version and regenerate this section, or drop the alpha-only clause f…

@btspoony btspoony closed this Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Release PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant