Repository navigation
ci: read the vouch list from the target branch's tip - #210
Merged
Merged
Conversation
The plan job read .github/VOUCHED.td at pull_request.base.sha, which stays at the base a pull request was opened against. Every pull request opened before the list existed found no list, so joshuaswarren's run on #166 was approved and then planned checks only. Read the list from the target branch by name: only merged changes reach it, so a pull request still cannot vouch for itself. Signed-off-by: Marcelo Alcantara <[email protected]>
[Medium impact] This change appears safe to merge. SummaryUpdates
Reviews (1) · Last reviewed commit: "ci: read the vouch list from the target ..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #208. The plan job read
VOUCHED.tdatpull_request.base.sha, which stays at the base a PR was opened against, not the current branch tip. Every PR opened before #208 merged therefore found no list.Still safe: only merged changes reach the protected branch, so a PR still can't vouch for its own author.
kernel-ci-approve.ymlalready reads the tip (github.shaonpull_request_target) and is unchanged.Evidence
approved run 40161075250 for joshuaswarren (vouched). The approved run then planned checks only:no .github/VOUCHED.td at faed71028380…(base.shaof ASoC: tas2764, tas2770: do not log a deferred probe as an error #166 is the merge of arm64: configs: asahi: build the Apple watchdog driver in #171, 2026-10-21).gh api …/contents/.github/VOUCHED.td?ref=refs/heads/integration/aurorareturns the 16 entries. actionlint and zizmor (pedantic) are clean.Merge Danger
Door: two-way
Blast Radius: CI cost
Team PRs opened before #208 now build in full, as #208 intended.