Skip to content

ci: read the vouch list from the target branch's tip - #210

Merged
maralcbr merged 1 commit into
integration/aurorafrom
ci/vouch-list-from-branch-tip
Oct 25, 2026
Merged

maralcbr merged 1 commit into
integration/aurorafrom
ci/vouch-list-from-branch-tip

Conversation

@maralcbr

Copy link
Copy Markdown
Member

Summary

Follow-up to #208. The plan job read VOUCHED.td at pull_request.base.sha, which stays at the base a PR was opened against, not the current branch tip. Every PR opened before #208 merged therefore found no list.

 Read the vouch list from the target branch
-  contents/.github/VOUCHED.td?ref=$BASE_SHA                 # pull_request.base.sha
+  contents/.github/VOUCHED.td?ref=refs/heads/$BASE_REF      # integration/aurora tip

Still safe: only merged changes reach the protected branch, so a PR still can't vouch for its own author. kernel-ci-approve.yml already reads the tip (github.sha on pull_request_target) and is unchanged.

Evidence

Merge Danger

Door: two-way

Blast Radius: CI cost

Team PRs opened before #208 now build in full, as #208 intended.

The plan job read .github/VOUCHED.td at pull_request.base.sha, which
stays at the base a pull request was opened against. Every pull request
opened before the list existed found no list, so joshuaswarren's run on
#166 was approved and then planned checks only. Read the list from the
target branch by name: only merged changes reach it, so a pull request
still cannot vouch for itself.

Signed-off-by: Marcelo Alcantara <[email protected]>
@greptile-apps

greptile-apps Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This change appears safe to merge.

Summary

Updates kernel-ci-jobs.yml to read .github/VOUCHED.td from the target branch’s current tip instead of pull_request.base.sha.

  • Kernel CI reads the vouch list from the target branch’s latest tip.

Reviews (1) · Last reviewed commit: "ci: read the vouch list from the target ..." · Reviewed by Greptile

@maralcbr
maralcbr merged commit 8b88dfc into integration/aurora Oct 25, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant