Repository navigation
drm/apple: dcp: init dimensions_wq in the announce test fixture (KVM KUnit timeout) - #168
Closed
iconidentify wants to merge 1 commit into
Closed
iconidentify wants to merge 1 commit into
iconidentify wants to merge 1 commit into
Conversation
dcp_comp_unbind() runs disable_work_sync(&dcp->dimensions_wq). The driver initialises that work in dcp_modes_init() (iomfb.c), but the external-announce KUnit fixture does not run that path and never initialised it, so every teardown case flushed an uninitialised work. Under TCG that only warned in __flush_work; under KVM the faster timing let the unbind diverge there and miss the test's pause point, so announce_unbind_running_hotplug_test (and its siblings) timed out waiting for t->paused. Initialise dimensions_wq with the fixture's noop worker like the other works. Also drop the six now-unneeded dimensions_wq entries from the CI's KUnit expected-warnings list. Signed-off-by: Chris Kearney <[email protected]> Co-Authored-By: Claude Opus 4.8 <[email protected]>
iconidentify
force-pushed
the
ci/kunit-dimensions-wq
branch
from
October 21, 2026 05:05
1f8d532 to
4ce90ae
Compare
Collaborator
|
Thanks, Chris. Already in via #169 (merged): it initialises |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the KUnit timeout Marcelo hit running the suites under KVM on the Namespace runner:
announce_unbind_running_hotplug_testtimed out waiting fort->paused, right after a__flush_workWARN fromdisable_work_syncindcp_comp_unbind.Root cause (not a driver race).
dcp_comp_unbind()callsdisable_work_sync(&dcp->dimensions_wq). The driver initialises that work indcp_modes_init()(iomfb.c:1444), but the external-announce KUnit fixture doesn't run that path and never initialiseddimensions_wq— so every teardown case was syncing an uninitialised work. Under TCG that only warned in__flush_work; under KVM the faster timing let the unbind diverge at that point and miss the test's pause, so the teardown cases timed out.Fix. Initialise
dimensions_wqwith the fixture's existing noop worker, exactly like the other works in the setup. This removes the WARN and the timeout — no need to force TCG, so KUnit keeps the KVM speedup (~3.5 min vs ~10). Also drops the six now-unneededdimensions_wqentries from the CI's KUnit expected-warnings.I can't reproduce KVM locally (x86 host), so I'm validating on the Namespace runner via the
ci:buildlabel on this PR — will confirm the timeout is gone there.🤖 Generated with Claude Code