Repository navigation
ci: fix package depmod/zstd, scope artifact reuse to non-PR runs, fix KUnit KVM timeout - #167
Closed
iconidentify wants to merge 1 commit into
Closed
iconidentify wants to merge 1 commit into
iconidentify wants to merge 1 commit into
Conversation
…hecks Two follow-ups from running the CI on the Namespace runner. Reuse (follow-up to #165): a reused kernel-package or kernel-verified artifact is now accepted only from a push, merge_group, schedule or workflow_dispatch run (REUSE_EVENTS), never a pull_request. A CI-only pull request from a writer has the same build key as the branch tip and could otherwise plant a package or verification record that a later queue or push run reuses before anyone reviews it. A comparison baseline (kernel-metadata) is only read, never substituted, so a pull_request run is still fine there (BASELINE_EVENTS). Package checks: inspect-package.py resolves module symbols with depmod and unpacks with tar --zstd, which the Namespace builder image does not ship. Install kmod and zstd in the package job when they are missing. Signed-off-by: Chris Kearney <[email protected]> Co-Authored-By: Claude Opus 4.8 <[email protected]>
iconidentify
force-pushed
the
ci/reuse-and-depmod
branch
from
October 21, 2026 05:05
b8f6d85 to
eaa454f
Compare
Collaborator
|
Thanks, Chris. Already in via #169 (merged):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the three CI fixes from the Namespace bring-up review.
1.
packagejob:depmod/zstdmissinginspect-package.pyshells out todepmod(and reads zstd-compressed modules), neither of which is on the Namespace image. Added a step tokernel-ci-jobs.ymlthat installskmodandzstdbefore the package checks, guarded so it is a no-op where they already exist.2. Reused artifacts must not come from PR runs (#165)
lookup-build.pynow scopes reuse ofkernel-package/kernel-verifiedartifacts topush,merge_group,scheduleandworkflow_dispatchruns only (REUSE_EVENTS).pull_requestruns are still accepted as baselines (BASELINE_EVENTS), so a fork PR can never hand a reused kernel package into a trusted run. Covered by two new unit tests; full suite (110) green, actionlint + zizmor (pedantic) clean.3. KUnit under KVM:
announce_unbind_running_hotplug_testtimeoutRoot cause was a test-fixture gap, not an emulation artifact. The external-announce fixture never runs the driver's real init paths, so four work items the code under test later drains were left uninitialised and flushed with a NULL
->func:dcp_comp_unbind()drainsdimensions_wq(driver inits it indcp_modes_init()).dcp_disable_typec_work()drainstypec_relink_wq,hdmi_settle_wq,hdmi_recheck_wq(driver inits them in its relink / HDMI setup).Under TCG these only warned in
__flush_work; under KVM the faster timing let the unbind diverge at that warning and miss the test's pause point, so the unbind test timed out ont->pausedand the three typec-stop cases tripped unexpected__flush_worksplats. The fixture now stubs all four works like the others, and the six now-unneededapple-dcp-external-announceentries are dropped fromkunit-expected.json. No--force-emulation workaround needed; this passes under KVM.Labeled
ci:buildso the full build/KUnit/package/boot jobs run here.🤖 Generated with Claude Code