Repository navigation
feat: 他プラグインが付与する no_see_death_message メタデータを尊重する - #33
Merged
Merged
Conversation
MoreFlags marks players who must not receive a death message with this metadata and defers the delivery to ToggleDeathMessage. v4 ignored it, so the MoreFlags death message flags had no effect. Treat such players as hiding and consume the metadata after every handled death event. Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01An7Jsqoey6TALGm294uYKf
Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01An7Jsqoey6TALGm294uYKf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
MoreFlags は、死亡メッセージを受け取れないプレイヤーにメタデータ
no_see_death_messageを付け、ToggleDeathMessage(TDM)が導入されている場合は再送信を TDM に任せます。v4 の TDM はこのメタデータを読まないため、併用すると MoreFlags のsend-death-message/receive-death-message/isolate-death-messageが全部無効になっていました。変更
no_see_death_messageメタデータを持つプレイヤーを、/tdm offと同様に「非表示」として扱います。検証
Paper 26.3 + WorldGuard 7.0.19 + MoreFlags(okocraft/MoreFlags#49 適用版)で、実 Bot が受信した結果を確認しました(14/14 PASS)。
send/receive/isolateが期待どおり動作します。/tdm offと MoreFlags のフラグを同時に使うと、両方の除外が効きます。未検証・注意
Generated by Claude Code