Publish: a date range keeps a trip's stops by their own dates - #38
Merged
Merged
Conversation
The range filtered trips by the trip's date, its first stop's day, and ignored the per-stop dates: a trip whose later stops fell in the range was left out, and one starting inside it was published whole, with every step on the first day. Date each stop by its own day or the last dated stop before it, and keep the stops inside the range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #31, whose branch it builds on; merge that first.
A trip from Paris on 2 May through Rome on 10 May to Cairo on 20 May vanishes from a site published for 8 to 31 May, and a site ending on 12 May shows Cairo. The publish range compares only the trip's first date, while each stop can now carry its own.
Each stop is now dated by its own date, or else by the last dated stop before it, or else by the trip's date, and a range keeps only the stops inside it. A trip appears when any of its stops is kept. The range is a window of days, and the site's visits and stories are already cut by day, so a trip is clipped rather than published whole. A trip without per-stop dates publishes exactly as before.