Repository navigation
fix: reports on real servers say the right thing (PRD-015, eval/12) - #25
Merged
Merged
Conversation
From the owner's review of their own scans (badssl.com and others), as a cryptographer, QA and PM: Scanner - When Go's TLS client cannot complete a handshake (3DES, RC4, NULL or small-DH suites only; an RSA certificate kept for RSA-only clients), the served chain is read from the raw TLS 1.2-and-earlier flights. Before, the no-SNI fallback certificate stood in for it. - The DH modulus is tested for primality and for being a safe prime. Evaluation (eval/12; stored scans are re-evaluated on start) - KX.DH-COMPOSITE (critical), KX.DH-NOT-SAFE-PRIME (low). - A missing issuer is an intermediate only when the leaf names its download URL (AIA); otherwise a root the stores do not hold. - CERT.COMPROMISED-ROOT for Superfish, eDellRoot, DSDTestProvider. - Revocation is "unknown" unless a verified staple vouches for it. - The untrusted-root wording covers public roots since removed. - The list's certificate expiry is the served leaf's, refreshed on re-evaluation (it showed the expired no-SNI placeholder). Screens - Fix first: three rows, one "when" chip each, the rest folded. - Every TLS version starts folded; version heads, suite rows and Fix first rows line up (measured: E2E-VIS-ALIGN). CRYPTO-REVIEW-003 and QA-REPORT-014 sign off; journey 240/0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The owner ran ~55 real scans (mostly badssl.com, where each host demonstrates one defect) and found reports that did not make sense, bad alignment, a broken-looking Fix first, and TLS versions open by default. Reviewed as a cryptographer, QA and PM against a copy of that database.
What was wrong, and the fix
Accuracy (eval/12; stored scans re-evaluate on start)
Screens
Evidence
go test ./...passes, including 5 new tests;golangci-lintreports 0 issues on Windows and Linux.Not released.