Repository navigation
feat(web): the SSH report, as instruments (PRD-014) - #24
Merged
Merged
Conversation
The SSH server report gets the one-stop Configuration PRD-013 gave TLS (UX-DESIGN-012): version and software, key exchange, host keys, ciphers, MACs and compression, and the baseline, under a sticky jump row. Every algorithm is a row with its bits bar, post-quantum glyph and baseline mark; host keys are cards; requirements are tiles linking to their source; baseline changes are chips in their parts; each part ends with its issues. The Summary gets the four-figure strip, and the baseline is line 1 of Fix first in the shared row shape. Journey: E2E-VIS-6 rewritten against sshAlgorithms; E2E-VIS-8, 9 and 10 added; E2E-H.2 reads the marks that replaced its words. 237 passed. CRYPTO-REVIEW-002 signed off; QA-REPORT-013; RTM rows REQ-SSV-1 to 9.
…hing to judge (eval/11) From the evaluation of PR #24: - next steps and the strict key exchange change name OpenSSH releases only to an OpenSSH server; any other server is told what to offer; - a truncated MAC is as strong as its tag (hmac-sha1-96 is 96 bits, not 128; SP 800-107 Rev. 1 section 5.3.5); - the RSA size rule says it does not apply when there is no RSA host key, instead of reading Met; - each should-be-off row says why on the row, in a wider column. eval/11 re-evaluates stored scans on start. Tests: TestSSHNextStepsNameOpenSSHOnlyForOpenSSH, TestRSASizeRuleWithoutAnRSAKeyDoesNotApply, TestTruncatedMACIsBoundedByItsTag.
# Conflicts: # web/static/style.css
…ORT-013) Records the owner-requested re-evaluation: five crypto defects fixed (two from the first review, three in eval/11), the should-be-off reasons on the row, the methodology's truncated-MAC rule and the CHANGELOG. Journey 238 passed, 0 failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #23 (base
feat/classes-and-x509); retarget tomainonce #23 merges.The SSH server report now uses the same "instruments, not paragraphs" layout PRD-013 gave the TLS report.
Docs: PRD-014, UX-DESIGN-012 (an addendum to UX-DESIGN-011; replaces its §3.5).
Configuration, one page in a reviewer's order, under a sticky jump row:
sshd_configlines with Copy.Each part ends with its issues and its baseline change chips. Sources sit in tooltips; there are no lists of citations.
Summary: readiness with its stepper, the baseline, the weakest classical strength (bits bar) and the host key. The baseline is line 1 of Fix first, in the shared row shape.
Tests:
sshAlgorithms.Sign-off: CRYPTO-REVIEW-002 is signed off with 2 fixes. QA-REPORT-013 covers the screen walk, with 3 fixes. RTM rows REQ-SSV-1 to 9 are added.
No change to the evaluation, the API or the PDF. No release.
Verified locally:
go test ./...passes.golangci-lint run ./...reports 0 issues on Windows and withGOOS=linux.