Document deaths_log per-death gold lost and time dead - #2973
Open
geracosta wants to merge 1 commit into
Open
Conversation
Companion to odota/parser#88: per-death {time, key, gold_lost, time_dead} for parsed matches, requested in odota#1465.
howardchung
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to odota/parser#88, for #1465. Closes #2294, closes #1780 (both fully covered: the log records every real death with its killing unit, heroes or not, suicides included). Adds
deaths_logto theParsedPlayertype and the match response OpenAPI schema: per-death{time, key, gold_lost, time_dead}for parsed matches.Same pattern as #2968: no inserts or migrations — the field lives in the parsed blob and flows to
GET /matches/{match_id}for newly parsed matches; older parses just don't have it.