Add deaths, assists and denies per minute benchmarks - #2970
Merged
Conversation
All three come from Steam API match data, no replay parsing required. The benchmark consumers iterate the shared metric map, so counts sampling, per-player match benchmarks and /benchmarks pick the new metrics up without further changes; OpenAPI schema updated to match.
howardchung
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of #2969: adds
deaths_per_min,assists_per_minanddenies_per_minto the benchmarks, following the same normalization as the existingkills_per_min/last_hits_per_min. All three come from Steam API match data, so no replay parsing is required and the sample size is the same as the current metrics.No new key dimensions — this only adds metrics to the existing global zsets. Since
counts,getPlayerBenchmarksandgetHeroBenchmarksall iterate the shared metric map, the only code change is the map itself plus the OpenAPI schema.One note:
deaths_per_minpercentiles read inverted (lower is better). I left the raw distribution for consistency with everything else, but happy to change that if you'd rather handle it differently.