[ADD] skills: odoo-git - #5282
Open
fvdsn wants to merge 1 commit into
Open
Conversation
Before this commit, the commit message format, the tag vocabulary, the target-branch rules and the pull request hygiene of the project lived in the git guidelines page of the documentation, the Contributing wiki, and the habits of the people merging. An agent writing a commit had to know to look in three places, and got the parts the docs leave out wrong: which trailers the bots add, how a cross-module header is written, how a dev branch is named. After this commit, skills/odoo-git/SKILL.md holds them in one file, since an agent making commits needs all of it at once: the commit message (header, tags, body, trailers, with a good and a bad example) and the branch and pull request rules. Every claim was checked against the last 20,000 commits on master: tag frequencies, header lengths (median 57, 90th percentile 71), the trailers authors write versus those the mergebot and forward-port bot add, the `module, *:` shape for cross-module changes, and the `<target>-<topic>-<trigram>` branch naming on odoo-dev.
|
This PR targets the un-managed branch odoo-dev/odoo:master-workspace-skills-fva, it needs to be retargeted before it can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #5250 (targets its branch so only this commit shows; retarget once it merges).
Adds
skills/odoo-git/, a single-file skill with Odoo's git conventions, for an agent writing or amending a commit message, choosing the branch a change targets, or opening or updating a pull request:[TAG] module: summaryheader (tag table,module, *:for cross-module changes, "if applied, this commit will ..." test, ~50 chars and never past 70), a why-first body, and reference trailers, with a good and a bad example on a schematic module.task-,opw-,runbot-,Fixes #,Co-authored-by) versus the ones the mergebot and forward-port bot add (closes,Signed-off-by,Related,X-original-commit,Forward-port-of,Part-of).<target>-<topic>-<trigram>branch naming, one change and one module per commit with[MOV]before[REF], rebase and squash, stable changes deferring to odoo-guidelines 0016.Sources: the git guidelines page of the documentation, the Contributing wiki, and the last 20,000 commits on master for what the docs leave out (tag frequencies, header lengths, bot-added trailers, header shapes, branch naming on odoo-dev).
One file rather than a guidelines folder: an agent making commits needs all of it at once.