[FIX] hr_holidays: improved ux when selecting a month in the accrual plan level view - #5266
Open
aryep-odoo wants to merge 1 commit into
Open
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-aryep, it needs to be retargeted before it can be merged. |
…plan level view Error was found when a new accrual plan level was being created and selected either the option 'yearly' or 'biyearly'. The error allowed the user to chose dates like '31st of February', '31 of November', etc. In order to reproduce it, anytime creating/editing a new Accrual Plan and adding or editing a Milestone you could see the inputs presenting the issue based on the 'frequency' in the first line of the 'Accrual Level Options'. The fix focused on making those fields into 'filterable_selection' fields which options could change dynamically based on other variables. task-6528269
aryep-odoo
force-pushed
the
master-hr-accrual_level_month_selection-aryep
branch
from
September 2, 2026 14:33
5d0452c to
2e0454a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error was found when a new accrual plan level was being created and selected either the option 'yearly' or 'biyearly'. The error allowed the user to chose dates like '31st of February', '31 of November', etc.
In order to reproduce it, anytime creating/editing a new Accrual Plan and adding or editing a Milestone you could see the inputs presenting the issue based on the 'frequency' in the first line of the 'Accrual Level Options'.
The fix focused on making those fields into 'filterable_selection' fields which options could change dynamically based on other variables.
task-6528269