[FIX] hr_holidays: Selecting time off type no longer triggers an error when creating a time off request via management - #5254
Open
feraz-odoo wants to merge 1 commit into
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-feraz, it needs to be retargeted before it can be merged. |
usseif97
requested changes
Aug 31, 2026
usseif97
left a comment
usseif97
left a comment
There was a problem hiding this comment.
Thanks for your work. The fix is to the point 🎯
Here's how bug-fix tasks are handled
You need to include on the PR description, the bug, steps to reproduce & how it solved
Also you should add a test to ensure that the issue doesn't reappear in the future and you should clearly add the test on the appropriate related test file
feraz-odoo
force-pushed
the
master-hr-onboarding-timeoff_type_selection_fix-feraz
branch
from
August 31, 2026 13:20
c9c0f39 to
cb6148c
Compare
feraz-odoo
added a commit
that referenced
this pull request
Aug 31, 2026
when creating a time off request via management Steps to reproduce: Time Off >> Configuration >> Time Off Types >> Open any type, navigate to the Smart button Time Off >> Click on New >> Time Off Type Reason: Bug was due to the is_valid function calling the operator with only one value instead of two. Solution: add value to op call Closes #5254 task-6522339
usseif97
reviewed
Sep 1, 2026
usseif97
requested changes
Sep 1, 2026
feraz-odoo
force-pushed
the
master-hr-onboarding-timeoff_type_selection_fix-feraz
branch
from
September 1, 2026 07:49
cb6148c to
8d661d6
Compare
feraz-odoo
added a commit
that referenced
this pull request
Sep 1, 2026
when creating a time off request via management Steps to reproduce: Time Off >> Configuration >> Time Off Types >> Open any type, navigate to the Smart button Time Off >> Click on New >> Time Off Type Reason: Bug was due to the is_valid function calling the operator with only one value instead of two. Solution: add value to op call Closes #5254 task-6522339
feraz-odoo
force-pushed
the
master-hr-onboarding-feraz
branch
2 times, most recently
from
September 1, 2026 11:53
5ec108e to
d6c97ce
Compare
when creating a time off request via management Steps to reproduce: Time Off >> Configuration >> Time Off Types >> Open any type, navigate to the Smart button Time Off >> Click on New >> Time Off Type Reason: Bug was due to the is_valid function calling the operator with only one value instead of two. Solution: add value to op call Closes #5254 task-6522339
feraz-odoo
force-pushed
the
master-hr-onboarding-timeoff_type_selection_fix-feraz
branch
from
September 1, 2026 11:57
8d661d6 to
55504a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce: Time Off >> Configuration >> Time Off Types >> Open any type, navigate to the Smart button Time Off >> Click on New >> Time Off Type
Reason: Bug was due to the is_valid function calling the operator with only one value instead of two.
Solution: add value to op call
task-6522339