[IMP] empty - #5248
Open
arpi-odoo wants to merge 4 commits into
Open
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding, it needs to be retargeted before it can be merged. |
arpi-odoo
force-pushed
the
master-hr-onboarding
branch
2 times, most recently
from
September 1, 2026 11:36
9019317 to
6734863
Compare
aryep-odoo
force-pushed
the
master-hr-onboarding-aryep
branch
from
September 1, 2026 12:04
e757f43 to
d70517f
Compare
…tab in employee The button to create new contract that was in the employee's payroll ta was appearing even when no contract dates were selected, which was incorrect behavior. Is a problem because in order to create a contract you need both starting and closing dates. To avoid code duplication the solution was to target the fix in the 'ButtonNewContract' custom widget that is only used in those views in all places (community, enterprise and addons). Now, it is dynamically verified if the 'contract_date_start' exists before rendering the button. task-6519063
aryep-odoo
force-pushed
the
master-hr-onboarding-aryep
branch
from
September 1, 2026 12:42
d70517f to
6f1e088
Compare
Aytime a Time Off was tried to be assigned through management an error was appearing when opening the field to select the type of it. To reproduce, it is only needed to try to create a leave from the management menu and opening the selection input for field for 'Time type' The problem was located in the search function for calculation of remaining leaves available to allocate, where the operator for comparison was being treated as a unary operator instead of binary. Solution was to update the calling function to it accetps the value to be compared against. task-6522957
In an Employee profile, on the 'Personal' tab there are many fields that are versioned, aka, they are linked to different contracts, so the values can changed or be updated through time. This wasn't the case for the fields 'certificate' and 'study_field', that could benefit from being versioned through different contracts. To achieve that, the fields were added to the HR Version class/model, following the same patterns for other fields in the same category. task-6522860 see odoo-dev/enterprise#1474
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.