Add the poster, and fix the CDN URL pointing at a version that does not exist - #16
Merged
Merged
Conversation
The README told everyone to load besttime@1, which means "newest 1.x". The published version is 0.1.0, so that URL returns 404 -- verified against jsDelivr: @1 is 404 and @0.1 is 200. Every one of the three references now says @0.1, and they go back to @1 when there is a 1.0.0 to point at. Also adds the poster at the top of the README, and the logo as an asset. The poster is resized to 1400px and reduced to a 32-colour palette, which takes it from 663 KB to 172 KB with no visible difference -- it is almost entirely flat black, one grey and white, so a palette costs it nothing. Badges for npm version, bundle size, dependency count, CI and licence, now that there is a published package for them to point at.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug this fixes
The README told people to load:
@1means "newest 1.x". The published version is0.1.0, so there is no 1.x and that URL 404s. Verified against jsDelivr:All three references (README ×2,
examples/html/index.html×1) now say@0.1. They go back to@1when there is a1.0.0to point at.Also
The poster, at the top of the README, plus the logo as an asset.
Resized to 1400px and reduced to a 32-colour palette: 663 KB → 172 KB, with no visible difference. The image is almost entirely flat black, one grey and white, so a palette costs it nothing and PNG compresses the result far better.
Badges — npm version, bundle size, dependency count, CI, licence. Worth having now that there is a published package for them to point at.
npm testpassesnpm run buildpasses