Repin to dpp-core 0.13.0: moved crates, JSON-LD context, catalog retention - #66
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dpp-core0.13.0 is published — all ten crates. This is no longer blocked and resolves from crates.io.Three changes, all forced by 0.13.0 rather than chosen here.
1. Crate boundaries
dpp-coresplit AAS and the trust layer into their own crates and moved the disclosure contract into the domain. Every edit here is an import path or a dependency line — no engine behaviour changes.SectorAccessPolicy,filter_by_audience,PolicyDecisiondpp_crypto::accessdpp_domain::accessTrustedIssuerRegistry,verify_credential_*dpp_cryptodpp_vcdid_builder,local_service,LocalIdentityService,PassportCredentialdpp_crypto::identitydpp_vcdpp-vcis added todpp-identity,dpp-nodeanddpp-vault.dpp-cryptostays forjwsandkeystore. Nodpp-aasdependency — the engine has no AAS references; serving that projection is separate work.Also absorbed: the sector axis opened on the wire, so
Sectoris no longerCopyandSector::Othercarries aString. Five sites — one unit-variant construction, two bind-then-move borrows, a metrics label needing an owned key, and one tuple pattern.2. The resolver consumes core's JSON-LD context
resolve_json.rsbuilt its own@contextreferencinghttps://odal-node.io/schemas/dpp/v1— which returns 404.dpp-vchad a second, different definition referencinghttps://ref.gs1.org/standards/digital-link/context/, which also 404s.A string entry in an
@contextarray is fetched by the consumer at expansion time, so a dead one fails a conforming processor outright and makes a lenient one drop every term it cannot define. Since passport payloads use bare keys, theld+jsondoor — which is this resolver's default response — conveyed no linked data at all.The handler now calls
dpp_vc::context_value(). One definition, one place to check.3. Retention reads from the catalog
dpp-coredeletedSector::minimum_retention_years. It was a hardcoded all-10s match, and it was what this engine actually applied when sealingPassport::retention_untilat publish — while the catalog manifests and two doc comments presentedSectorDescriptor::retention_yearsas authoritative.All three call sites — the seal in
publish.rs, the deletion guard inlifecycle.rs, and the Art. 13 archive call — now read one resolver,retention_years_for: the catalog's value for the sector, else a ten-year floor.Corrected — this started as fail-closed and was reversed on the branch; the body described the earlier behaviour until now. The first pass refused to publish a sector with no catalog entry and blocked its deletion outright, on the argument that an obligation of unknown length has no safe default. What that missed is that the case is reachable in ordinary use rather than exotic: a passport carrying no sector data at all resolves to
Sector::Other, and the sector axis opening in 0.13.0 means a passport can now name a product group this build has never seen. Refusing to publish those is a larger behaviour change than sourcing a retention period warrants.Ten years is not a number invented for the occasion — it is what every sector in the catalog declares, and
docs/legal/DPP-RETENTION.mdrecords it as the floor across all of them, pending delegated acts included. Applying it keeps data at least as long as any known obligation requires. Applying the same resolver at all three sites also means the deletion guard and the sealedretention_untilcannot disagree, which the fail-closed version did not guarantee:u32::MAXin the guard against a ten-year seal is a contradiction, and the guard was the side that would have won.Verification
just checkexit 0 against the published 0.13.0, not path overrides: 586 tests run, 586 passed, 0 skipped.Cargo.lockis committed in this PR — held back deliberately until publish, since it could not be generated correctly while the versions were unresolvable. It now recordsregistry+https://github.com/rust-lang/crates.io-indexfor every core crate.