Repository navigation
fix(warnings): compile the DPI helper only where it is called - #18
Merged
Merged
Conversation
`SetHighDPIv2Scaling()` is called from the one place in `WinMain` that is guarded by `#if CHROME_VERSION_BUILD < 5615`. With the CEF version this fork pins, the call is compiled out and the definition is left as an unreferenced static, which is C4505 in the MSVC /W4 app build (obs-rust/obs-studio#2626, `obs-browser-helper.vcxproj`). Guarding the definition with the same condition keeps the two in step for every CEF version. No behaviour change: where the call survives, the definition survives.
Member
Author
|
Superseded for obs-rust/obs-studio#2691: while I was writing this, a sibling worker landed the same lane green with a target-level Keeping this open as the root-cause alternative — the definition and its only call site sit under the same |
zackees
commented
Oct 28, 2026
zackees
left a comment
zackees
left a comment
Member
Author
There was a problem hiding this comment.
Coordinator review — correct and minimal.
SetHighDPIv2Scaling()has exactly one caller,obs-browser-page-main.cpp:90, and that call sits inside#if CHROME_VERSION_BUILD < 5615. With a newer CEF the whole path is compiled out, so the static becomes unreferenced and MSVC /W4 reports C4505. Guarding the definition with the same condition is the right fix; the alternative (an[[maybe_unused]]or a dummy reference) would hide the real condition.CHROME_VERSION_BUILDis already used a few lines below in the same file, so the guard needs no new include.- The translation unit keeps its other content (
shutdown_check_threadand the rest), so nothing becomes an empty TU, and no header declares the helper (it isstatic). - Comment names the diagnostic (C4505) and the reason, which is what the surrounding code does for its other warning fixes.
checks is green (1 passed). Merging; obs-browser has no merge queue and no required checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetHighDPIv2Scaling()is only called from theWinMainfallback inside#if CHROME_VERSION_BUILD < 5615. With the CEF version obs-rust/obs-studio pins, that call is compiled out, so the definition is an unreferenced static — C4505, which is fatal in the MSVC /W4 app build (obs-browser-helper.vcxproj), blocking obs-rust/obs-studio#2626's Windows lane.This guards the definition with the same condition as the call, so the two cannot drift for any CEF version. No behaviour change: where the call survives, the definition survives.
Found by the
/W4app-lane verification on obs-rust/obs-studio#2691 (run 40762415176,Build windows arm64). obs-rust/obs-studio's side bumps this submodule pointer tod4276de.