refactor: resolve SonarCloud quick-win code smells - #110
Merged
Merged
Conversation
|
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Resolves the open SonarCloud code smells reported on
nyg_kraken-api-java, fixing the mechanical ones and suppressing the ones that reflect deliberate API design.Tests
assertThatThrownBy(builder::build), so the lambda holds a single call that can throw.KrakenAPIcredential tests use method references such asunit::accountBalanceinstead of lambdas.LedgerInfoEndpointTestasserts withcontainsEntry.throws ExceptionfromTradeVolumeEndpointTest.Library
DefaultKrakenRestRequesteruses aCONTENT_TYPEconstant for the header name.DepositLimitDeserializerandLimitValueDeserializercatchNumberFormatExceptionwith an unnamed variable.JsonPostParamsmatches the nonce with\dinstead of[0-9], which is equivalent since Java's\dis ASCII-only by default.WalletAccountsParams.params()returns the map directly.CreateFundingWithdrawalParams.fee()returns an empty map instead ofnullwhen no fee option is set, andbody()only addsfeewhen it is not empty. A set fee always containsquoted_feeorcurrent_fee, so the encoded body is unchanged.Suppressed
PostParams.params(): subclasses override it returning eitherMap<String, String>orMap<String, Object>, which the wildcard allows; removing it would break subclasses of the published API.KrakenAPI: it is the single entry point exposing every endpoint by design.FundingBetaParams.body():nullis the documented way for an endpoint to send no body, distinct from an empty JSON object.Remaining