feat: add individual github, linkedin, portfolio website, and resume question types - #128
Merged
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit b406098): https://dev-nwplus-admin--pr128-36205849471-1nu2xe7f.web.app (expires Tue, 06 Oct 2026 00:43:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c290bf9e2fac0401389f751f415cce4267517b51 |
geoff-jiang
reviewed
Sep 25, 2026
| "School", | ||
| "Major", | ||
| "Country", | ||
| "Github", |
Contributor
There was a problem hiding this comment.
These four fixed questions are available in every section, but the portal saves their answers under the selected section. For example, GitHub in Basic Info writes basicInfo.github instead of skills.github (I see in your Portal PR these are meant to be in skills section only). Could we limit these types to Skills, or otherwise ensure they always save to the intended skills.* fields?
geoff-jiang
approved these changes
Sep 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason
Explanation
Other considerations