Skip to content

feat: add individual github, linkedin, portfolio website, and resume question types - #128

Merged
shannonaurl merged 7 commits into
devfrom
shannon/application-changes
Sep 26, 2026
Merged

shannonaurl merged 7 commits into
devfrom
shannon/application-changes

Conversation

@shannonaurl

Copy link
Copy Markdown
Contributor

Reason

  • support Portfolio unwrapping in the application by replacing Portfolio with its four question types (github, linkedIn, portfolio website, resume), so that each can be separately set to be required/optional on the application

Explanation

  • added Github, LinkediN, Portfolio Website and Resume to the new question types to the QUESTION_TYPES/QUESTION_TYPES_UNIQUE
  • updated HackerApplicationQuestionType to include new types

Other considerations

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit b406098):

https://dev-nwplus-admin--pr128-36205849471-1nu2xe7f.web.app

(expires Tue, 06 Oct 2026 00:43:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c290bf9e2fac0401389f751f415cce4267517b51

"School",
"Major",
"Country",
"Github",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These four fixed questions are available in every section, but the portal saves their answers under the selected section. For example, GitHub in Basic Info writes basicInfo.github instead of skills.github (I see in your Portal PR these are meant to be in skills section only). Could we limit these types to Skills, or otherwise ensure they always save to the intended skills.* fields?

@shannonaurl
shannonaurl merged commit c1978a0 into dev Sep 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants