Repository navigation
Pin common and shim for Policies-then-Preferences lookup - #1501
Merged
Merged
Conversation
GPO/Intune ADMX values now win over machine preferences in the shim and CLI. Signed-off-by: Corey Butler <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin
commonto5006246(nvm-windows/common#23) andshimto82ccd5f(nvm-windows/shim#23).Why
GPO/Intune writes
Software\Policies. The shim used to read only Preferences for cooldown,LogExecutions,AutoUse, and several other ADMX keys. Lookup is now HKLM Policies, HKLM Preferences, HKCU Policies, HKCU Preferences. Machine policy still always wins. Usernvm configstill applies when nothing higher is set.Testing
zig build test43/43 on shim#23go testpreferences + settings on common#23 (HKCU policy ignored for security keys; HKLM policy wins; HKCU pref fallback still works)Risk
Low. HKLM Policies already won for permission/V8/lifecycle. This extends that order to the remaining ADMX keys. HKCU Policies no longer beat HKLM Preferences (user GPO cannot override machine prefs). ADMX is machine-class, so that is the intended lock.