Repository navigation
fix: enforce version firewall and PE on nvm use - #22
Merged
Merged
Conversation
ActivateVersion calls acl.IsAllowedVersion and compares node.exe FileVersion to the folder so policy and swap attacks fail at use. Signed-off-by: Corey Butler <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
nvm use/ActivateVersioncallsacl.IsAllowedVersionbefore changing the active version (NVM4411)ActivateVersioncomparesnode.exeFileVersion to the folder version (NVM4314)node.exeskips the PE check so activation tests still runWhy
Version firewall only ran at install. A later allow/block list did not stop
nvm use. Authenticode still trusts an official Node 10 binary dropped into av24.0.0folder.Testing
go test ./installer/(parseCoreVersion, swap mismatch, missing exe skip, non-PE reject)Risk
Community
common/aclstub still always allows. PE check is fail-closed whennode.exeexists without VERSIONINFO.