Repository navigation
Skip mirror SHASUM when local_install_only - #21
Merged
Merged
Conversation
Local-only installs must not fetch SHASUMS256.txt after resolving an exact version from a staged archive. Signed-off-by: Corey Butler <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
local_install_onlyis on, skip live mirror SHASUM fetches for a staged archive.Why
After exact-version catalog skip, Community air-gap installs still downloaded SHASUMS256.txt. That second network call failed the same hosts. Trust the staged archive the same way machine-policy LocalInstallDir already does.
Testing
TestVerifyCachedNodeArchiveIntegrityLocalOnlySkipsMirrorTestCLIInstallLocalOnlyMissingArchivenow asserts zero catalog HTTP hitsRisk
Low. Online installs still verify via mirror SHASUM. A bad local SHASUM sidecar still fails closed.