Repository navigation
fix(cli): put expanded LocalAppData .nodejs on HKCU PATH - #20
Merged
Merged
Conversation
Electron copies PATH without expanding %LOCALAPPDATA%, so integrated terminals cannot find node/npm. Write only %LOCALAPPDATA%\Author Software\nvm\.nodejs. Signed-off-by: Corey Butler <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
%LOCALAPPDATA%\Author Software\nvm\.nodejson HKCU Path during bootstrap and--remove-legacy-user-env.%LOCALAPPDATA%form. Skip empty or service-profile LocalAppData.Why
Electron copies PATH without expanding
%LOCALAPPDATA%. Integrated terminals then cannot find node/npm even when nvm works. Machine PATH stays unexpanded for every user. HKCU gets the expanded LocalAppData path the installer already forces (NVM4100 //DIRignored).Testing
go test ./bootstrapRisk
Low. Writes HKCU Path only. Does not change program root,
InstallRoot, or machine PATH.