Conversation
- migrate `list_rounds` from deprecated GraphQL round multiplier fields to the full public `roundScoreConfigs` surface for Classic, Signals, and Crypto - preserve the six established Corr/MMC return keys through numerapi 2.x as exact-name compatibility projections, without mapping Alpha/FNC to Corr or MPC to MMC - document old/new response shapes, the numerapi 2.24.0 migration, planned 3.0.0 removal, and the isolated deprecated `round_model_performances_v2` endpoint - keep Ruff CI stable across unpinned Ruff releases by recording the repository's historical lint selection
The `v3UserProfile` GraphQL field accepts a `tournament` argument that disambiguates a model name within a tournament. The old Classic/Signals implementations ignored it — meaning a name shared across tournaments could resolve to the **wrong** model's id (verified: `quixotic15` returns a different id with vs. without `tournament=12`). This unifies all three tournaments into a single `base_api.Api.public_user_profile` that passes `tournament=self.tournament_id`: - ✅ `CryptoAPI` gains `public_user_profile` (tournament 12) — the missing piece - ✅ Signals / Classic now resolve names within their own tournament (11 / 8) - ✅ duplicated overrides in `numerapi.py` and `signalsapi.py` removed (DRY) Return shape is unchanged (`id`, `username`, `startDate`, `bio`, `nmrStaked`).
Query the current stake field, `stakeValue` (type `Nmr`), directly within the
signals tournament and parse it to `Decimal`, returning `None` for models with
no stake (instead of raising):
```python
query = '''
query($model_name: String!, $tournament: Int) {
v3UserProfile(model_name: $model_name, tournament: $tournament) {
stakeValue
}
}
'''
```
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c546404b4b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: numerai-hosted-agent-bot[bot] <247676148+numerai-hosted-agent-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before merging, ensure chaneglog is updated and announcement is crafted.