Repository navigation
Format what cleanup --forward handed to dotnet format - #374
Merged
Merged
Conversation
A fix can shorten a line Curb had broken, and dotnet format does not join it. After the forwarded invocations succeed in a write run, Curb's formatter now runs over the files they were handed. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After
cleanup --forwardapplies a fix throughdotnet format, the changed files are no longer in Curb's layout when the fix shortened a line Curb had broken, socurb checkfails (#372). A write run now runs Curb's formatter over the files the forwarded invocations were handed (the whole target, or the explicit files, when an invocation was not scoped to files).--checkchanges nothing.Verify: the full suite passes (2283). The new test rewrites a file through a fake forwarded tool and fails with the formatting step disabled.
curb check src tools testsand./build.sh optionsare clean.Closes #372
🤖 Generated with Claude Code