Skip to content

Format what cleanup --forward handed to dotnet format - #374

Merged
Mpdreamz merged 1 commit into
mainfrom
fix/cleanup-forward-formats
Nov 16, 2026
Merged

Mpdreamz merged 1 commit into
mainfrom
fix/cleanup-forward-formats

Conversation

@Mpdreamz

Copy link
Copy Markdown
Contributor

After cleanup --forward applies a fix through dotnet format, the changed files are no longer in Curb's layout when the fix shortened a line Curb had broken, so curb check fails (#372). A write run now runs Curb's formatter over the files the forwarded invocations were handed (the whole target, or the explicit files, when an invocation was not scoped to files). --check changes nothing.

Verify: the full suite passes (2283). The new test rewrites a file through a fake forwarded tool and fails with the formatting step disabled. curb check src tools tests and ./build.sh options are clean.

Closes #372

🤖 Generated with Claude Code

A fix can shorten a line Curb had broken, and dotnet format does not join it.
After the forwarded invocations succeed in a write run, Curb's formatter now runs over
the files they were handed.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@Mpdreamz Mpdreamz added the bug A defect fixed (patch) label Nov 16, 2026
@Mpdreamz
Mpdreamz merged commit 01ae235 into main Nov 16, 2026
10 checks passed
@Mpdreamz
Mpdreamz deleted the fix/cleanup-forward-formats branch November 16, 2026 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A defect fixed (patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cleanup --forward leaves the files it changed unformatted

1 participant