Repository navigation
Bump every dependency to its latest version - #32
Merged
Merged
Conversation
Mono.Cecil 0.11.6, ILRepack.Lib 2.0.48, MinVer 8.0.0, Nullean.Argh 0.27.2, Nullean.Make.Fs 0.27.2, Proc.Fs 0.20.0, the local tools and the GitHub Actions. MinVer 5 removed the pre-release phase: canary becomes the identifiers canary.0, which yields the same versions. nupkg-validator 0.11 needs the validate subcommand and never knew --allow-roll-forward, and Make.Fs 0.27 makes -s a switch. assembly-differ stays on 0.17.0 (0.18.x crashes in previous-nuget, nullean/assembly-differ#62) and is listed before nupkg-validator so a cold tool restore succeeds. MinVer now applies only to packable projects; build/scripts never used it. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
…ssembly-differ to 0.18.2 Argh 0.28.0 includes nullean/argh#139, so a bare `assembly-rewriter -i … -o …` no longer prints a spurious "unknown short option" before it runs through the root alias; the comment about the workaround goes. assembly-differ 0.18.2 fixes previous-nuget (nullean/assembly-differ#62); the build moves to its `diff` subcommand with `-a` as a switch. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings every dependency of assembly-rewriter, the GitHub Actions included, to its latest version, and adapts the build to the tools whose command lines changed.
Prompt summary: Bring every dependency, GitHub Actions included, to its latest version, drop unused and sponsor-gated packages, and release the nullean repositories in dependency order.
What
global.json(11.0.100) and the other actions were already on the latest.build/scripts, which is not packed.Directory.Build.propsnow adds it only to packable projects.Changes forced by the bumps:
MinVerDefaultPreReleasePhase.canarybecomesMinVerDefaultPreReleaseIdentifierscanary.0(and--default-pre-release-identifiers canary.0for the CLI), which computes the same versions (0.14.6-canary.0.4).validatesubcommand.--allow-roll-forwardwas dropped: no version of the validator has that option, so 0.10.1 ignored it.-sa switch, sopublishcontainers -s truebecomespublishcontainers -sinci.yml.diffsubcommand and makes-aa switch.generateapichangesnow runsassembly-differ diff … -a, and-f github-commentis kept.assembly-rewriter -i … -o …(the root alias Pass the rewrite subcommand from the GitHub Action #33 keeps for olderaction.ymlarguments) no longer prints a spurious "unknown short option". The comment inProgram.csthat described that workaround is removed.Breaking: none for consumers. assembly-rewriter is a tool, so its dependencies ship inside it.
Verify
mise run ci: build, pack,nupkg-validator validate(both TFMs signed with 96c599bbe3e70f5d, version 0.14.6-canary.0.4),assembly-differ diff0.18.2 against the publishedassembly-rewriter.any,curb check(0 would change). All pass.mise run check: curb clean, zizmor no findings.actionlint(with shellcheck): clean.zizmor --min-severity medium .github: no findings.NUGET_PACKAGES=$(mktemp -d) DOTNET_CLI_HOME=$(mktemp -d) dotnet tool restore: "Restore was successful".check-package-readme.shpasses on both nupkgs.dotnet list package --outdated --include-transitive: nothing listed. The sponsor-package grep overproject.assets.jsonprints nothing.-i … -o …andrewrite -i … -o …both exit 0 with no "unknown short option", and their outputs are byte-identical, with theElasticsearch.Net620names in place.dotnet pack -r osx-arm64(native AOT) succeeds and the Mach-O arm64 binary runs (--help,rewrite --help). The bare form prints no "unknown short option".main's AOT binary, built for comparison, printsError: unknown short option '-i'.for the same command.SignAssemblyto false makesmise run cifail invalidatepackages("NOT publicly signed with expected token"). After the revert it passes again.Found, not changed here (pre-existing on
main, same failure there):DefaultAssemblyResolverfinds framework assemblies throughTRUSTED_PLATFORM_ASSEMBLIES, which native AOT does not set, so Elasticsearch.Net (netstandard1.3 and net46) and a net10.0 dll all fail withAssemblyResolutionException(for example System.Diagnostics.Debug or System.Private.CoreLib), with or without-r <shared framework dir>.AssemblyResolverreads its-rhits without passing itself on as the resolver, so facades fail on their forwards. The managed build is not affected. This matters for theghcr.io/nullean/assembly-rewritercontainer thataction.ymlruns, and belongs in a separate fix.--merge(-m) fails onmain(ILRepack 2.0.18:ArgumentOutOfRangeException) and still fails here (ILRepack 2.0.48 tries to resolveIKVM.RuntimebecauseLineIndexation = true). WithLineIndexation = falsethe merge succeeds on 2.0.48, which also belongs in a separate fix.🤖 Generated with Claude Code