Repository navigation
Conversation
The action ran diff with two provider specs and a free-form args string, and did nothing on the pull request. It now installs the tool, compares the solution's libraries or a package, and runs pull-request: comment, release label, and fail-on with the breaking-allowed label. Inputs are typed and it has outputs. The old first, second and args inputs still run diff in the container image, with a deprecation warning. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uses: nullean/assembly-differ@v1now compares a pull request's libraries with their last release, comments, sets the release-drafter label, and fails on a breaking change until the pull request gets thebreaking-allowedlabel. The old inputs still work.Prompt summary: The action's arguments are hard to use, and there is no clear path to hooking it up to pull requests. It should set the
breakinglabel, fail, and pass once a configurable allow label is added: the author makes a breaking change, the action detects it, labels it and fails, the author adds the allow label, and the next run succeeds.Why
The action ran
assembly-differ diff <first> <second> <args>in a container: two provider specs and a free-form string. It had no outputs and did nothing on the pull request. Wiring it up took a hand-written workflow around it.What
A composite action
It installs the tool with
dotnet tool, so the solution mode can read the projects with the SDK the build already set up. Withoutpackageit runsprojects, comparing every library of the solution inworking-directorywith its latest release; withpackageit runsreleaseon that.nupkg. The report goes toapi-changes.json, andpull-requestputs it on the pull request.Typed inputs and outputs
The inputs are
package,projects,target,framework,fail-on(defaultmajor),allow-label(defaultbreaking-allowed), the three label names,comment,labels,working-directory,tokenandversion. The outputs aresuggested-change,breaking-changesandreport. Every input reaches the scripts through environment variables, never through${{ }}insiderun:, sozizmorreports no findings. The tool is called by path, not added toGITHUB_PATH.The old inputs
first,secondandargsstill rundiffinghcr.io/nullean/assembly-differ:edge, with the workspace mounted as before, and print a deprecation warning.README
A workflow to copy, with the
labeledandunlabeledevents that make adding the allow label rerun the check, a table of inputs, and what happens on a pull request from a fork.Verify
I ran the steps' scripts locally against argh's solution and a Proc package, with a stand-in for the installed tool. The solution suggested
Noneand passed. The package suggestedMajorwith 5 breaking changes, set the outputs, and exited4underfail-on: major.Out of scope: The action installs the latest released tool, and
pull-request --fail-on --allow-labelarrives in #83. So the new path works from the first release that carries #83, which is planned as 1.0, the release that also creates thev1tag.🤖 Generated with Claude Code