Repository navigation
win32: return 23 from a pull that could not write a file - #4
Open
nikitatsym wants to merge 2 commits into
Open
nikitatsym wants to merge 2 commits into
nikitatsym wants to merge 2 commits into
Conversation
nikitatsym
force-pushed
the
fix-receiver-exit-status
branch
from
October 1, 2026 17:28
573b110 to
433cfea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a pull into Windows cannot write or rename a file, rsync prints the error but exits with 0 instead of 23. The receiver runs as a thread here and the thread always ended with status 0, while on POSIX the forked receiver exits with 23. This change ends the receiver thread with the same status, and a new exit_codes test checks both push and pull. It also gives keep.txt a fixed mtime in test_batch.py, because that test raced on the clock and the new exit status turns the race into a failure.