Repository navigation
win32: let transfers at protocol 29 and 30 finish - #3
Open
nikitatsym wants to merge 1 commit into
Open
nikitatsym wants to merge 1 commit into
nikitatsym wants to merge 1 commit into
Conversation
nikitatsym
force-pushed
the
fix-receiver-goodbye-below-31
branch
from
October 1, 2026 17:28
0657a23 to
e657840
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the client speaks protocol 29 or 30, like the openrsync that ships with macOS, a push into a Windows receiver copies all files but never exits, and a pull from such a server fails with code 12. The receiver thread waits for a last message that only protocol 31 and later send, and the SIGUSR2 that ends the receiver on POSIX does nothing to a thread. This change waits for that message only at protocol 31 and later and makes SIGUSR2 wake the receiver thread; a new test covers protocols 29 and 30.